Ensure unique identity values within identity managed collections#4333
Merged
Conversation
…gement the next identity value will be unique within the collection. Fixes #3581
rockfordlhotka
approved these changes
Nov 21, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures that before adding an item to a collection with identity management the next identity value will be unique within the collection.
Fixes #3581
The actual problem isn't the graph merger but the identity values assigned beforehand. In the reported case the fetch+add didn't generate unique identity values within one collection.
My main concern with this fix would be a performance impact because now each insert has to verify it gets an unique identity value. But I couldn't come up with another solution because I can't know if an insert is harmless or not :-/