Remove binary formatter net data contract serializer#4018
Merged
rockfordlhotka merged 5 commits intoJun 12, 2024
Merged
Conversation
Removed `application/x-microsoft.net.object.binary.base64` mimetypes and associated serialization instructions from `.resx` files. Also, deleted `BinaryFormatterWrapper.cs` and `NetDataContractSerializerWrapper.cs` files, indicating a shift away from `BinaryFormatter` and `NetDataContractSerializer` serialization methods.
Updated `SerializationTests.cs` to use `MobileFormatter` instead of `NetDataContractSerializer` and `BinaryFormatterWrapper`. The `using` statements have been rearranged accordingly. The `[Ignore]` attribute has been added to `TestSerializableEventsActionFails()` and `TestSerializableEventsActionSucceeds()` methods, possibly indicating these tests are currently not in use. The `UseCustomSerializationFormatter()` and `UseNetDataContractSerializer()` methods in the `CommandOverDataPortal()` method have been removed.
rockfordlhotka
requested changes
Jun 11, 2024
Removed two ignored tests from `SerializationTests.cs` that were previously designed to assess the serialization capabilities of objects with event handlers. These tests, `TestSerializableEventsActionFails` and `TestSerializableEventsActionSucceeds`, were no longer relevant due to changes in the testing strategy or updates to the serialization mechanism, suggesting a shift in focus or improvements that made these specific tests obsolete.
rockfordlhotka
approved these changes
Jun 12, 2024
luizfbicalho
deleted the
remove-BinaryFormatter-NetDataContractSerializer
branch
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4001