Make WaitForIdle() methods virtual so a user can extend it's functionality#3979
Merged
Conversation
Reorganze WaitForIdle() methods to reduce code duplication
| /// Await this method to ensure business object is not busy. | ||
| /// </summary> | ||
| /// <param name="timeout">Timeout duration</param> | ||
| public virtual Task WaitForIdle(TimeSpan timeout) |
Member
There was a problem hiding this comment.
Is there a way to have just one virtual overload?
I've done this before, with two virtual overloads that "do the same thing" and it becomes a serious point of confusion and bugs for people who overload the method(s) over time.
Contributor
Author
There was a problem hiding this comment.
Yeah. I'll think about a proper solution :)
rockfordlhotka
requested changes
Jun 1, 2024
rockfordlhotka
approved these changes
Jun 2, 2024
StefanOssendorf
added a commit
that referenced
this pull request
Jun 2, 2024
rockfordlhotka
pushed a commit
that referenced
this pull request
Jun 3, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@rockfordlhotka
During the changes I've become unhappy with the currenty
WaitForIdle()structure, because a user would now have to override two methods to get consistent behavior. The methods withTimeSpanandCancellationTokenbecause the first throws aTimeoutExceptionand the latter aTaskCanceledException. I understand why both implementation use different exceptions but from a user perspective it's awkward to override two methods to have consistent behavior. Any ideas?