Adapt new MariaDB v10.11.5 Support (additional related changes on top of original PR #771) #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheKnowles
reviewed
Sep 17, 2023
| String dbName = "mariaDB4jTestWSecurity"; // or just "test" | ||
| if (!"test".equals(dbName)) { | ||
| // mysqld out-of-the-box already has a DB named "test" | ||
| // in case we need another DB, here's how to create it first | ||
| db.createDB(dbName, "root", ""); | ||
| db.createDB(dbName, "root", randomRootPassword); |
There was a problem hiding this comment.
This is a good solution.
Maria 10.4 changed authentication where the root user now has an invalid password. So you have to "be" root in order to run commands OR as the user that owns the process (user.name here) has to run SET PASSWORD for the root account. This test could change over to just using the current user/owner, but I wanted to keep logic changes to minimum to account for system changes from 10.2.11 to 10.11.5.
There was a problem hiding this comment.
This test could change over to just using the current user/owner,
@TheKnowles feel free to raise a new PR re. this if you are motivated.
TheKnowles
reviewed
Sep 17, 2023
mariaDB4j/src/test/java/ch/vorburger/mariadb4j/tests/MariaDB4jSampleTutorialTest.java
Outdated
Show resolved
Hide resolved
TheKnowles
reviewed
Sep 17, 2023
DBs/mariaDB4j-db-10.11.5/mariaDB4j-db-winx64-10.11.5/prepare.xml
Outdated
Show resolved
Hide resolved
vorburger
force-pushed
the
vorburger-minor-changes-on-top-of-PR-771-for-MariaDB-v10.11.5
branch
2 times, most recently
from
cfd75a2 to
12b0db6
Compare
vorburger
changed the title
vorburger
force-pushed
the
vorburger-minor-changes-on-top-of-PR-771-for-MariaDB-v10.11.5
branch
from
12b0db6 to
834f156
Compare
vorburger
force-pushed
the
vorburger-minor-changes-on-top-of-PR-771-for-MariaDB-v10.11.5
branch
from
834f156 to
6f4191e
Compare
vorburger
force-pushed
the
vorburger-minor-changes-on-top-of-PR-771-for-MariaDB-v10.11.5
branch
from
6f4191e to
689af5c
Compare
includes bumping MariaDB v10.11.5 Windows binary to 10.11.5-fix1; see #771 for details.
vorburger
force-pushed
the
vorburger-minor-changes-on-top-of-PR-771-for-MariaDB-v10.11.5
branch
from
689af5c to
b03b6fe
Compare
vorburger
deleted the
vorburger-minor-changes-on-top-of-PR-771-for-MariaDB-v10.11.5
branch
This was referenced Sep 18, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a number of adaptions on top of PR #771 from @TheKnowles.
@TheKnowles FYI