Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test PR to see if the Windows issue is fixed #649

Merged
merged 4 commits into from
Apr 17, 2023
Merged

Test PR to see if the Windows issue is fixed #649

merged 4 commits into from
Apr 17, 2023

Conversation

vorburger
Copy link
Collaborator

This PR combines #647 with #638 to see if it works (together).

@vorburger vorburger self-assigned this Dec 10, 2022
@vorburger
Copy link
Collaborator Author

Huh - interesting... this seems to fail differently, and even earlier already, than #638 did.

@MazenAmria @jejanim would you be interested in further analyzing what's going on here?

@MazenAmria
Copy link
Contributor

@vorburger sure

@MazenAmria
Copy link
Contributor

@vorburger

https://github.com/vorburger/MariaDB4j/blob/b71a54494dc01e6d00cff7818a632e3a12fea122/mariaDB4j/src/test/java/ch/vorburger/mariadb4j/tests/MariaDB4jSampleTutorialTest.java#L50-L58

This is trying to use the path /usr as a base directory which doesn't exist in Windows.
The test is trying to run D:\usr\scripts\mysql_install_db.exe, note that other tests was running something like:C:\Users\RUNNER~1\AppData\Local\Temp\MariaDB4j\base\bin\mysql_install_db.exe.

btw, the test that was failing due to --tmpdir has passed, I'm not sure if that's enough to verify my PR.

@vorburger
Copy link
Collaborator Author

This is trying to use the path /usr as a base directory which doesn't exist in Windows. The test is trying to run D:\usr\scripts\mysql_install_db.exe, note that other tests was running something like:C:\Users\RUNNER~1\AppData\Local\Temp\MariaDB4j\base\bin\mysql_install_db.exe.

Oh! Right; well spotted. So that test covers the https://github.com/vorburger/MariaDB4j#how-using-existing-native-mariadb-binaries scenario. @jejanim do you think it would be possible to, like for the Linux tests, install MariaDB4j on Windows in the Github Workflow? (Somehow; I don't know how.)

Then we could have this test pass, and cover that use case on Windows (which would be nice...) by putting an if (config.isWindows()) (by refactoring to pull the config.build() out/up) and setting the base dir and executable to wherever it typically is installed on Windows.

@vorburger
Copy link
Collaborator Author

possible to install MariaDB4j on Windows in the Github Workflow? (Somehow; I don't know how.)

https://github.com/ankane/setup-mariadb from @ankane looks pretty interesting for this!

@vorburger
Copy link
Collaborator Author

Sorry for the long silence on this. I've fixed a number of others things in this project today, and am hoping to find time another weekend to upgrade the project overall from Java 11 to Java 17 and then be able to pick this PR up....

PS: If you use MariaDB4j professionally, please consider either taking a Tidelift subscription or GitHub Sponsor to support future maintenance!

@vorburger
Copy link
Collaborator Author

Hah! NOW All checks have passed - after I have done (hacked) #713.

I'll do some git rebase and then (finally, sorry) merge this now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants