-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test PR to see if the Windows issue is fixed #649
Conversation
Huh - interesting... this seems to fail differently, and even earlier already, than #638 did. @MazenAmria @jejanim would you be interested in further analyzing what's going on here? |
@vorburger sure |
This is trying to use the path btw, the test that was failing due to |
Oh! Right; well spotted. So that test covers the https://github.com/vorburger/MariaDB4j#how-using-existing-native-mariadb-binaries scenario. @jejanim do you think it would be possible to, like for the Linux tests, install MariaDB4j on Windows in the Github Workflow? (Somehow; I don't know how.) Then we could have this test pass, and cover that use case on Windows (which would be nice...) by putting an |
https://github.com/ankane/setup-mariadb from @ankane looks pretty interesting for this! |
Sorry for the long silence on this. I've fixed a number of others things in this project today, and am hoping to find time another weekend to upgrade the project overall from Java 11 to Java 17 and then be able to pick this PR up.... PS: If you use MariaDB4j professionally, please consider either taking a Tidelift subscription or GitHub Sponsor to support future maintenance! |
Hah! NOW All checks have passed - after I have done (hacked) #713. I'll do some |
- Cache dependencies - Expose testreports
This PR combines #647 with #638 to see if it works (together).