Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features #230, Dynamic package with direct download of mariadb #235

Merged
merged 1 commit into from
Sep 1, 2019
Merged

Features #230, Dynamic package with direct download of mariadb #235

merged 1 commit into from
Sep 1, 2019

Conversation

srbala
Copy link
Contributor

@srbala srbala commented Mar 14, 2019

@vorburger This PR resolves #230

@jtmuhone Would be able to review this pr

@vorburger
Copy link
Collaborator

vorburger commented Mar 14, 2019

@jtmuhone I would also very much love your thoughts what you think about this, as an alt to your #229..

jtmuhone
jtmuhone previously approved these changes Mar 14, 2019
@jtmuhone
Copy link
Contributor

jtmuhone commented Mar 14, 2019

Is the MacOS binary file downloaded from homebrew? The homebrew binary is not statically linked. See https://formulae.brew.sh/api/formula/mariadb.json, there is a dependency to openssl and the binary wont work without installing it. I couldn't find a statically linked binary, and thats why I compiled the binaries myself. It wasn't easy, since I don't have a Mac.

@srbala
Copy link
Contributor Author

srbala commented Mar 14, 2019

@jtmuhone that is good point, we may want document it as necessary external dependency similar to libncurses.so.5 in fedora (documented), libaio1 in ubuntu and visual c++ library 2013 in windows environments.

@vorburger what do you think?

@jtmuhone
Copy link
Contributor

jtmuhone commented Mar 19, 2019

The openssl requirement is homebrew related and needs to be installed using homebrew. My co-worker, who tested my PR got this error message while I was using a binary downloaded from homebrew:

dyld: Library not loaded: @@HOMEBREW_PREFIX@@/opt/openssl/lib/libssl.1.0.0.dylib
  Referenced from: /Users/kolsa/dev/tests/MariaDB4j/mariaDB4j/target/MariaDB4jSpringServiceOverrideBySpringValueTest/baseDir/bin/mysqld
  Reason: image not found
Abort trap: 6

I'm pretty sure, that you can't use the homebrew binary.

@srbala
Copy link
Contributor Author

srbala commented Mar 19, 2019

@jtmuhone, @vorburger So can we skip the Mac from dynamic package?

@jtmuhone
Copy link
Contributor

Also, at least where I work, our build hosts don't have universal Internet access.

vorburger
vorburger previously approved these changes Sep 1, 2019
Copy link
Collaborator

@vorburger vorburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - let me finally merge this. Thanks for contributing.

Really so very sorry it took this long to get this PR in! Do send more PRs.

I've opened new issue #288 re. Mac.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic package with direct download of mariadb
3 participants