-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features #230, Dynamic package with direct download of mariadb #235
Conversation
Is the MacOS binary file downloaded from homebrew? The homebrew binary is not statically linked. See https://formulae.brew.sh/api/formula/mariadb.json, there is a dependency to |
@jtmuhone that is good point, we may want document it as necessary external dependency similar to @vorburger what do you think? |
The openssl requirement is homebrew related and needs to be installed using homebrew. My co-worker, who tested my PR got this error message while I was using a binary downloaded from homebrew:
I'm pretty sure, that you can't use the homebrew binary. |
@jtmuhone, @vorburger So can we skip the Mac from dynamic package? |
Also, at least where I work, our build hosts don't have universal Internet access. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - let me finally merge this. Thanks for contributing.
Really so very sorry it took this long to get this PR in! Do send more PRs.
I've opened new issue #288 re. Mac.
@vorburger This PR resolves #230
@jtmuhone Would be able to review this pr