Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test coverage for locally pre-installed MariaDB on Windows #713

Closed
vorburger opened this issue Apr 17, 2023 · 1 comment · Fixed by #781
Closed

Add test coverage for locally pre-installed MariaDB on Windows #713

vorburger opened this issue Apr 17, 2023 · 1 comment · Fixed by #781
Labels
dependencies helpwanted high Windows Anything specific to Microsoft Windows OS, not affecting Linux

Comments

@vorburger
Copy link
Collaborator

I will move forward with #649 by adding an isWindows() to MariaDB4jSampleTutorialTest for testLocalMariaDB() to unblock wrapping that up.

The goal of this issue, for which I ask for and would welcome community contributions, would be to add test coverage for locally pre-installed MariaDB on Windows by re-enabling that test.

https://github.com/ankane/setup-mariadb seems like a great GitHub Action for this project; I recommend to try to add that at least the Windows GitHub Action, but for uniformity perhaps to the Linux one as well (and Mac, if one is written in #497 by the time someone contributes this).
@vorburger vorburger added high helpwanted dependencies Windows Anything specific to Microsoft Windows OS, not affecting Linux labels Apr 17, 2023
vorburger referenced this issue Apr 17, 2023
@vorburger
Skip testLocalMariaDB() if isWindows()
74d943b 
See https://github.com/vorburger/MariaDB4j/issues/713
This was referenced Apr 17, 2023
Open
Merged
@vorburger
Copy link
Collaborator Author

@jejanim @MazenAmria @TareqK @TheKnowles perhaps this interest you to contribute? Just a thought! 😄

vorburger referenced this issue Apr 17, 2023
@vorburger
Skip testLocalMariaDB() if isWindows()
22aefa2 
See https://github.com/vorburger/MariaDB4j/issues/713
vorburger referenced this issue Apr 17, 2023
@vorburger
Skip testLocalMariaDB() if isWindows()
60b8bac 
See https://github.com/vorburger/MariaDB4j/issues/713
@TheKnowles TheKnowles mentioned this issue Sep 20, 2023
Merged
vorburger pushed a commit that referenced this issue Sep 21, 2023
@TheKnowles
test: Added Windows MariaDB install action & enabled local mariadb te…
1787e24 
…st for Windows (#781 fixes #713)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies helpwanted high Windows Anything specific to Microsoft Windows OS, not affecting Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added Windows mariadb install action. Enabled local mariadb test for … TheKnowles/MariaDB4j
1 participant
@vorburger