MDEV-32637 Implement native UUID7 function by StefanoPetrilli · Pull Request #3093 · MariaDB/server

StefanoPetrilli · 2024-02-29T18:13:00Z

The Jira issue number for this PR is: MDEV-32637

Description

MariaDB provides the UUID method that generates UUID v1, however, UUID v1 generates non-linear UUIDS that will spread data across different linear partitions based on key or hash.

The new UUID7 (https://uuid7.com/) will guarantee that continuous records are time-sorted and a good collision resistance.

The main advantage of the UUID7 function is that it will allow MariaDB to avoid the limitation of using a unique combined primary key for time series records, where a unique ID and a date are required to create key/hash partitions. With UUID7 is possible to only use the key as ID and time reference.

Release Notes

Adds the function:
UUIDv7(): returns a UUIDv7

How can this PR be tested?

This PR adds automatic tests that partially test the new functions.

I am not aware of an easy way to change the time retrieved by my_hrtime(), hence, I could not write automatic tests to verify that the UUIDs generated are monotonic.
I am open to suggestions on how to accomplish that.

Basing the PR against the correct MariaDB version

This is a new feature and the PR is based against the latest MariaDB development branch.
This is a bug fix and the PR is based against the earliest maintained branch in which the bug can be reproduced.

PR quality check

I checked the CODING_STANDARDS.md file and my PR conforms to this where appropriate.
For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.

CLAassistant · 2024-02-29T18:13:06Z

All committers have signed the CLA.

grooverdan

Well done on the depth of initial implementation.

mysys/my_uuid_v7.c

plugin/type_uuid/plugin.cc

sql/mysqld.cc

plugin/type_uuid/mysql-test/type_uuid/func_uuidv7_plugin.test

mysql-test/main/func_misc.test

plugin/type_uuid/mysql-test/type_uuid/order.test

mysql-test/main/rpl_row_UUIDv7.test

mysys/my_uuid_v7.c

dlenski

Other than the issue of breaking time-sortability if you build up too much "borrowed time" and then restart the server (CREATE new_table AS SELECT UUID7(), T.* FROM table_with_1_million_rows T), this looks really good to me. 🙌

dlenski

Other than my small remaining nitpick about the name(s) of the constant(s), this looks fantastic. Approving! 🙌

mysys/my_uuid_v7.c

LinuxJedi

Great work! A few minor things to fix and I think we are there.

Later on (not for this Jira ticket or PR) we could add a test for this to check that the UUID timestamp is within a tolerable range of a timestamp (+/- 2 hours?) in the same column by creating a new function to extract the UUID timestamp. If we do it range based then we won't need to worry about monotonic / DST quite as much.

mysys/my_uuid_v7.c

dlenski · 2024-03-14T17:27:54Z

@LinuxJedi wrote:

we could add a test for this to check that the UUID timestamp is within a tolerable range of a timestamp (+/- 2 hours?) in the same column by creating a new function to extract the UUID timestamp. If we do it range based then we won't need to worry about monotonic / DST quite as much.

Since it's based on Unix-epoch timestamp, shouldn't need to worry about DST 😅

plugin/type_uuid/item_uuidfunc.h

vuvova

UUID code is pretty good, just doesn't need to reside in mysys.
The function could be greatly simplified by using the approach from https://github.com/MariaDB/server/tree/bb-11.5-bar-MDEV-11339 (after rebasing this PR on top of that branch).

@StefanoPetrilli , I know you're busy now. There's no hurry, you can get back to it after GSoC. Just, please, if you decide not to continue with the PR at all — add a comment and say so.

include/my_sys.h

mysql-test/main/rpl_row_UUIDv7.test

mysys/my_uuid_v7.c

plugin/type_uuid/item_uuidfunc.cc

vuvova · 2024-08-22T21:10:06Z

you've marked all my comments as resolved without actually changing anything. how comes?

StefanoPetrilli · 2024-08-25T16:09:16Z

you've marked all my comments as resolved without actually changing anything. how comes?

Hey @vuvova, now you should be able to see the changes, I messed up while pushing.

vuvova · 2024-09-02T15:06:00Z

I still don't see any changes 🤷‍♂️

vuvova · 2024-09-12T16:58:18Z

Thanks. I've cherry-picked both UUIDv4 and UUIDv7 code into bb-11.7-MDEV-33710-uuid branch to be tested and merged into main

vuvova · 2024-10-30T20:15:33Z

pushed into 11.7, thanks!

StefanoPetrilli force-pushed the 11.5-MDEV-32637 branch 2 times, most recently from b34c8c2 to 155ab93 Compare February 29, 2024 19:18

grooverdan reviewed Mar 1, 2024

View reviewed changes

StefanoPetrilli force-pushed the 11.5-MDEV-32637 branch from 155ab93 to 025fc56 Compare March 5, 2024 09:44

StefanoPetrilli requested a review from grooverdan March 5, 2024 09:47

StefanoPetrilli force-pushed the 11.5-MDEV-32637 branch 2 times, most recently from 2d216a3 to e3496f2 Compare March 5, 2024 12:11

dlenski reviewed Mar 5, 2024

View reviewed changes

mysql-test/main/func_misc.test Outdated Show resolved Hide resolved

dlenski reviewed Mar 6, 2024

View reviewed changes

plugin/type_uuid/mysql-test/type_uuid/order.test Show resolved Hide resolved

StefanoPetrilli force-pushed the 11.5-MDEV-32637 branch from e3496f2 to 46bef2a Compare March 6, 2024 19:13

dlenski approved these changes Mar 6, 2024

View reviewed changes

mysql-test/main/rpl_row_UUIDv7.test Show resolved Hide resolved

mysys/my_uuid_v7.c Outdated Show resolved Hide resolved

dlenski reviewed Mar 6, 2024

View reviewed changes

mysys/my_uuid_v7.c Outdated Show resolved Hide resolved

dlenski approved these changes Mar 6, 2024

View reviewed changes

StefanoPetrilli requested a review from dlenski March 10, 2024 18:24

StefanoPetrilli force-pushed the 11.5-MDEV-32637 branch 2 times, most recently from ba470e7 to 344bb52 Compare March 10, 2024 19:20

dlenski approved these changes Mar 12, 2024

View reviewed changes

mysys/my_uuid_v7.c Outdated Show resolved Hide resolved

LinuxJedi reviewed Mar 13, 2024

View reviewed changes

mysys/my_uuid_v7.c Outdated Show resolved Hide resolved

mysys/my_uuid_v7.c Outdated Show resolved Hide resolved

mysys/my_uuid_v7.c Outdated Show resolved Hide resolved

StefanoPetrilli force-pushed the 11.5-MDEV-32637 branch from db143ce to 6bfbb8c Compare March 13, 2024 22:49

StefanoPetrilli requested a review from LinuxJedi March 13, 2024 22:59

StefanoPetrilli force-pushed the 11.5-MDEV-32637 branch 3 times, most recently from c1cc665 to 96be6e7 Compare March 13, 2024 23:51

StefanoPetrilli force-pushed the 11.5-MDEV-32637 branch from 96be6e7 to b923baf Compare March 25, 2024 14:56

grooverdan requested a review from abarkov March 26, 2024 01:35

abarkov reviewed Apr 2, 2024

View reviewed changes

plugin/type_uuid/item_uuidfunc.h Show resolved Hide resolved

StefanoPetrilli force-pushed the 11.5-MDEV-32637 branch from b923baf to 5dc0e30 Compare April 2, 2024 20:45

StefanoPetrilli requested a review from abarkov April 2, 2024 20:46

grooverdan requested a review from vuvova April 30, 2024 01:49

vuvova requested changes Jun 10, 2024

View reviewed changes

MDEV-32637 Implement native UUID7 function

2ed2901

StefanoPetrilli force-pushed the 11.5-MDEV-32637 branch from 5dc0e30 to 3d65dd8 Compare July 24, 2024 13:39

StefanoPetrilli changed the base branch from 11.5 to 11.6 July 24, 2024 13:40

StefanoPetrilli requested a review from vuvova July 24, 2024 13:46

removes borrowed time

5545c0d

StefanoPetrilli force-pushed the 11.5-MDEV-32637 branch from 3d65dd8 to 5545c0d Compare August 25, 2024 16:07

vuvova closed this Oct 30, 2024

Uh oh!

Conversation

StefanoPetrilli commented Feb 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Release Notes

How can this PR be tested?

Basing the PR against the correct MariaDB version

PR quality check

Uh oh!

CLAassistant commented Feb 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

grooverdan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dlenski left a comment

Choose a reason for hiding this comment

Uh oh!

dlenski left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

LinuxJedi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dlenski commented Mar 14, 2024

Uh oh!

Uh oh!

vuvova left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vuvova commented Aug 22, 2024

Uh oh!

StefanoPetrilli commented Aug 25, 2024

Uh oh!

vuvova commented Sep 2, 2024

Uh oh!

vuvova commented Sep 12, 2024

Uh oh!

vuvova commented Oct 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

7 participants

StefanoPetrilli commented Feb 29, 2024 •

edited

Loading

CLAassistant commented Feb 29, 2024 •

edited

Loading