Skip to content

v1.4.2 is broken #289

Closed
Closed

Description

@dhilt

It was released 1 hour ago and broke my tests in the following nice (not) way:

Screenshot 2022-01-09 at 23 49 28

I fixed it in my lib by reverting package-lock.json: dhilt/ngx-ui-scroll@dd782fc (BTW it is suggested to downgrade to 1.4.0, thanks to @lirantal, so here's another downgrade commit)

I suppose it might relate to destruction of the Faker.js project (5 days ago): https://github.com/Marak/faker.js

Activity

  1. Hamahmi commented on Jan 9, 2022

    @Hamahmi

    It is, check this commit 074a0f8

  2. floscher commented on Jan 9, 2022

    @floscher

    See #285

  3. lirantal commented on Jan 9, 2022

    @lirantal

    @dhilt please revert back to using 1.4.0 if you can to mitigate the issue.
    Versions 1.4.1 and 1.4.2 would both introduce a denial of service upon usage.

  4. dhilt commented on Jan 9, 2022

    @dhilt
    Author

    @lirantal Thanks, will do!

  5. Apollon77 commented on Jan 9, 2022

    @Apollon77

    @Marak Can you please kill 1.4.1 and 1.4.2 from npm and adjust latest back to 1.4.0 please ... It is breaking a lot!

  6. pxseu commented on Jan 9, 2022

    @pxseu

    @Marak Can you please kill 1.4.1 and 1.4.2 from npm and adjust latest back to 1.4.0 please ... It is breaking a lot!

    That's.... the point of why he has done that

  7. dustinlw1987 commented on Jan 9, 2022

    @dustinlw1987

    Marak should NOT be trusted as a developer! Especially after doing this unilaterally without notification.

  8. DABH commented on Jan 9, 2022

    @DABH
    Contributor

    Please consider closing this issue so that people will go to #285 instead -- trying to keep solutions and updates in one place. Thanks.

  9. dustinlw1987 commented on Jan 9, 2022

    @dustinlw1987

    @Marak Can you please kill 1.4.1 and 1.4.2 from npm and adjust latest back to 1.4.0 please ... It is breaking a lot!

    That's.... the point of why he has done that

    There is absolutely NO REASON to fuck over people this way! That's how you burn bridges and have people not trust you as an developer.

  10. pxseu commented on Jan 9, 2022

    @pxseu
  11. dustinlw1987 commented on Jan 9, 2022

    @dustinlw1987

    Sure, and that is EXACTLY what is happening. Marak is being cut out and deleted as nobody trusts him now.

  12. Apollon77 commented on Jan 10, 2022

    @Apollon77

    In my eyes there are two sides right now:
    1.) The present and how to fix the real issue ... ideally supporting him that he hopefully reverts latest on npm to 1.4.0
    2.) Future: Then the affected libraries can think about movingg away or whatever

    I'm interested rigt now in Point 1 ...

  13. shayneoneill commented on Jan 10, 2022

    @shayneoneill

    "ideally supporting him"

    Yeah, no. That would be deeply irresponsible. Not after this. Rewarding this sort of malicious behavior just leads to more of it.

  14. DevXiaolan commented on Jan 10, 2022

    @DevXiaolan

    Did it so

  15. rsadr0pyz commented on Jan 10, 2022

    @rsadr0pyz

    npx marak-free

  16. karikera commented on Jan 10, 2022

    @karikera

    v1.4.1 is also broken
    v1.4.0 is working

  17. euberdeveloper commented on Jan 10, 2022

    @euberdeveloper

    Hi, in case the author will not maintain this project or fix this, I made a fork that restores the normal behaviour. I am not sure if I will maintain this package, but just in case the problem will not be solved and you don't want to be scared when running npm update...

    https://github.com/euberdeveloper/colors.js

    In any case I could also suggest passing to the chalk package, which is very good and has a serious and reliable author

  18. RIAEvangelist commented on Jan 10, 2022

    @RIAEvangelist

    Here is an alternative, optionally, you could easily write your own module :

    nozaki-colors https://github.com/RIAEvangelist/nozaki-colors

  19. TechStudent10 commented on Jan 10, 2022

    @TechStudent10

    @npm revert it to a working version.

  20. serenecloud commented on Jan 10, 2022

    @serenecloud
  21. TechStudent10 commented on Jan 10, 2022

    @TechStudent10
  22. dhilt commented on Jan 10, 2022

    @dhilt
    Author

    Great, closing this as npm has removed broken versions and reverted to 1.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions