Fix not detecting inherited il2cpp members #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where inherited IL2CPP members were not being properly detected by refactoring the member collection system to use an enum-based approach instead of boolean flags.
- Replaced boolean
getStaticparameters with aGetAllTypeenum that supportsBoth,InstanceOnly, andStaticOnlymember types - Simplified the IL2CPP member collection logic by removing complex field pointer matching and using unified method info pointer lookup
- Updated all member collection calls to use the new enum-based API
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| RuntimeUnityEditor.Core/Utils/Extensions.cs | Added GetAllType enum and refactored extension methods to use enum instead of boolean parameters |
| RuntimeUnityEditor.Core/Windows/Inspector/MemberCollector.cs | Updated all member collection calls to use the new enum-based API |
| RuntimeUnityEditor.Core/Windows/Inspector/IL2CPP/MemberCollector.IL2CPP.cs | Simplified IL2CPP pointer lookup logic and added inheritance check |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
RuntimeUnityEditor.Core/Windows/Inspector/IL2CPP/MemberCollector.IL2CPP.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.