Fix long member values messing up list scrolling in inspector #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
RuntimeUnityEditor.Core/Windows/Inspector/Inspector.cs:16
- Renaming the constant and changing its accessibility from private to internal requires verifying that external references are updated accordingly. Please confirm that the broader codebase does not depend on the original private declaration.
internal const int InspectorRecordInitialHeight = 25;
RuntimeUnityEditor.Core/Windows/Inspector/Inspector.cs:411
- Using a hard-coded value (130) for calculating visible scroll area may lead to display inconsistencies on different screen sizes or window configurations. Consider refactoring this logic to calculate the offset dynamically based on runtime measurements.
var scrollMaxVisibleY = scrollPositionY + ((int)WindowRect.height - 130);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.