Add godots cli open command. #28
Conversation
artsich
force-pushed
the
main
branch
2 times, most recently
from
64b8243 to
42e8052
Compare
src/main/cli_main.gd
Outdated
|
|
||
| if (parsed_args.size() >= 1): | ||
| if "open" in parsed_args: | ||
| pass |
src/main/main.gd
Outdated
| _exit() | ||
| else: | ||
| print("Run window mode") | ||
| add_child.call_deferred(windowMainScene.instantiate()) |
There was a problem hiding this comment.
seems like we don't need to preload it
add_child.call_deferred(load("res://src/main/window_main.tscn").instantiate())and remove line::3
const windowMainScene: PackedScene = preload("res://src/main/window_main.tscn")
src/services/local_editors.gd
Outdated
| for e in all(): | ||
| if (e.name.contains(name)): | ||
| return e; | ||
| return null; |
src/services/local_editors.gd
Outdated
| func retrieve_by_name_pattern(name: String) -> LocalEditor: | ||
| for e in all(): | ||
| if (e.name.contains(name)): | ||
| return e; |
src/services/local_editors.gd
Outdated
|
|
||
| func retrieve_by_name_pattern(name: String) -> LocalEditor: | ||
| for e in all(): | ||
| if (e.name.contains(name)): |
There was a problem hiding this comment.
e.name.findn(name) > -1should be better
src/services/local_editors.gd
Outdated
| tags_edited.emit() | ||
|
|
||
| func open(args: PackedStringArray): | ||
| print("Run editor with arguments: ", args) |
There was a problem hiding this comment.
use
Output.push("Run editor with arguments: %s" % args)
artsich
changed the title
artsich
force-pushed
the
main
branch
2 times, most recently
from
da0f241 to
3795cab
Compare
src/services/local_editors.gd
Outdated
|
|
||
| const dir = preload("res://src/extensions/dir.gd") | ||
|
|
||
| const mac_os_editor_path_postfix = "/Contents/MacOS/Godot" |
There was a problem hiding this comment.
var mac_os_editor_path_postfix:
get: return _section.get_value("mac_os_editor_path_postfix", "/Contents/MacOS/Godot")
src/services/local_editors.gd
Outdated
| var pid = OS.create_process(process_args.path, process_args.args) | ||
|
|
||
| if (pid == -1): | ||
| Output.push('An array occured when create editor process') |
There was a problem hiding this comment.
'An array...' looks like a typo
artsich
force-pushed
the
main
branch
2 times, most recently
from
e098469 to
09cc361
Compare
artsich
force-pushed
the
main
branch
2 times, most recently
from
5de7a7f to
9296e87
Compare
|
@JillyMan, can you consider adding Godots cli argument Am not sure this proposal is in the scope of your commit ,however, any response will be appreciated |
Hi @SeremTitus I'm fine with this cli argument. Will do it in separate PR. |
3 participants
Example of usage
Godots.exe --headless -open=4.1.1 -- --path "C:/Users/cli-godot-example" "C:/cli-godot-example/main.tscn" -- -game_arg true