Set static hostname for antispam to preserve history. #1837
Merged
bors[bot] merged 2 commits intoMailu:masterfrom Jun 29, 2021
Diman0:561-antispam-history
Merged
Set static hostname for antispam to preserve history. #1837bors[bot] merged 2 commits intoMailu:masterfrom Diman0:561-antispam-history
bors[bot] merged 2 commits intoMailu:masterfrom
Diman0:561-antispam-history
Conversation
Contributor
|
Thanks for submitting this pull request. bors try Note: if this build fails, read this. |
Contributor
|
bors r+ |
mergify
Bot
dismissed
decentral1se’s stale review
Pull request has been modified.
Contributor
|
Build succeeded: |
Contributor
tryBuild succeeded: |
nextgens
added
the
type/backport
bors Bot
added a commit
that referenced
this pull request
Jul 18, 2021
1866: Set static hostname for antispam to preserve history. (backport #1837) r=mergify[bot] a=mergify[bot] This is an automatic backport of pull request #1837 done by [Mergify](https://mergify.io). --- <details> <summary>Mergify commands and options</summary> <br /> More conditions and actions can be found in the [documentation](https://docs.mergify.io/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.io/) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.io/ </details> Co-authored-by: Dimitri Huisman <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR?
bug-fix
What does this PR do?
It addresses bug #561. Rspamd stores the history in redis. The key for storing the history contains the hostname. On recreation of the docker container, the hostname changes and for this reason the rspamd history is lost. Setting a fixed hostname resolves this. Upon recreating the antispam container the history is retained.
Related issue(s)
Prerequistes
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.