one div too much in index.php#8
Closed
geraldbaeck wants to merge 10 commits intoMagicMirrorOrg:masterfrom
geraldbaeck:master
Closed
one div too much in index.php#8geraldbaeck wants to merge 10 commits intoMagicMirrorOrg:masterfrom geraldbaeck:master
geraldbaeck wants to merge 10 commits intoMagicMirrorOrg:masterfrom
geraldbaeck:master
Conversation
Collaborator
|
css now included with link rel="stylesheet" and without php - This gives caching issues when you update the CSS file. Adding a timestamp does not solve this. |
Author
|
seems that i submitted to many commits. i only wanted to submit the index.html stuff, sorry. |
Author
|
Hi, i wrote a node.js port of the magicmirror https://github.com/geraldbaeck/node-magicmirror |
kepps2113
pushed a commit
to kepps2113/MagicMirror
that referenced
this pull request
Dec 8, 2019
* adding new config altering the transition function sugnature * altering the transition function sugnature * altering the transition function sugnature * add functionality for per position rotating * correcting indexing of positions array * change show hide spped to make for cleaner transitions * update README reorder the defaults * correct typos in README * refactor to reduce repeated code * refactor to reduce repeated code * refactor to reduce repeated code * refactor to reduce repeated code * move var declarations * fixing errors in the build * fixing errors in the build * fixing errors in the build * fixing errors in the build * fixing errors in the build * fixing errors in the build * fixing errors in the build * fixing errors in the build * fixing errors in the build * fixing errors in the build * adding the first pass of my slides implementation * refactor to reduce repeated code * refactor to reduce repeated code * protecting a call to undefined * fixing bad call() * fixing my undefined checks * JSLINT alternative ideas on checking for undefined * trying to fix the unit tests * trying to fix the unit tests * update README to include new options * update README to include new options * fix typos in readme
DonIsaac
pushed a commit
to DonIsaac/MagicMirror
that referenced
this pull request
Sep 12, 2020
fix:previous
MichMich
pushed a commit
that referenced
this pull request
Dec 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was one extra which i deleted. I also made identations.