Skip to content

refactor: unify favicon for index.html and Electron#4006

Merged
rejas merged 1 commit intoMagicMirrorOrg:developfrom
KristjanESPERANTO:favicon
Jan 5, 2026
Merged

refactor: unify favicon for index.html and Electron#4006
rejas merged 1 commit intoMagicMirrorOrg:developfrom
KristjanESPERANTO:favicon

Conversation

@KristjanESPERANTO
Copy link
Collaborator

@KristjanESPERANTO KristjanESPERANTO commented Jan 4, 2026

In #3407 we already talked about unifying them.

  • Create SVG favicon (better then png)
  • Replace base64 placeholder in index.html with SVG favicon
  • Update electron.js to use SVG favicon instead of mm2.png
  • Add favicon.svg to server static routes
  • Remove mm2.png

@KristjanESPERANTO
refactor: unify favicon for index.html and Electron
6508b07 
- Replace base64 placeholder in index.html with SVG favicon
- Update electron.js to use same favicon.svg instead of mm2.png
- Add favicon.svg to server static routes
- Remove obsolete mm2.png file
@sdetweil
Copy link
Collaborator

sdetweil commented Jan 4, 2026

sorry, I don't remember conversation about this.. what problem does it solve?

@KristjanESPERANTO
Copy link
Collaborator Author

KristjanESPERANTO commented Jan 4, 2026

sorry, I don't remember conversation about this.

No problem. I see, you apparently didn't participate in the PR discussion.

what problem does it solve?

It doesn't really solve anything, it's just cleaner and more consistent.

@sdetweil
Copy link
Collaborator

sdetweil commented Jan 4, 2026

it's just cleaner and more consistent.

as compared to what?

how does it help our users, our product and our team?
you mention electron, how about all the other browsers available? are there version restrictions?

I am not an active software developer, never have been. current trends also never interested me.
reliability, stability, supportability and maintainability have always been my focus.

i am against change for change sake.

@khassel
Copy link
Collaborator

khassel commented Jan 4, 2026

I vote for this change.

  • It's technical a more modern solution than the existing one
  • it unifies the icons used in electron and server-only
  • it replaces the ugly grafik in server-only

@khassel khassel requested a review from rejas January 4, 2026 22:44
@rejas
Copy link
Collaborator

rejas commented Jan 5, 2026

I also vote for this change, modernizing stuff helps in the long term.

@rejas rejas merged commit 9731ea2 into MagicMirrorOrg:develop Jan 5, 2026
9 checks passed
@KristjanESPERANTO KristjanESPERANTO deleted the favicon branch January 5, 2026 13:53
@KristjanESPERANTO KristjanESPERANTO mentioned this pull request Jan 5, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rejas rejas rejas approved these changes

@khassel khassel khassel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@KristjanESPERANTO @sdetweil @khassel @rejas