fix: set compliments remote file minimum delay to 15 minutes#3970
Conversation
|
Was set long intentionally. But configurable if need to be changed. Most won’t change every 15 minutes. Maybe daily. The default should not be fast |
|
I agree with @sdetweil Maybe we just set the default value to 1 day and also adjust the comment there accordingly? 15 hours seems kinda strange indeed |
|
Yeh, I made it hours instead of minutes, but didn’t change 15 to 12 |
|
The comment along the code said 15 minutes. But default value can be one day, agreed, as long as the comment matches and the value is configurable. |
|
To clarify, the I don't see why My use case is: the remote file is updated by multiple sources throughout the day, and I'd like the mirror to pull these changes multiple times a day. |
|
Ok, I see your point Minimum 15 minutes seems ok. Which is what I intended but pasted an extra * 60 |
Yes, I think the logic was correct, just a typo 😄 |
|
@sdetweil So we can merge this, right? 🙂 |
|
Yes |
Thanks to: @Blackspirits, @Crazylegstoo, @jarnoml, @jboucly, @JHWelch, @khassel, @KristjanESPERANTO, @rejas, @sdetweil, @xsorifc28⚠️ This release needs nodejs version >=22.21.1 <23 || >=24 [Compare to previous Release v2.33.0](v2.33.0...develop) [core] Prepare Release 2.34.0 (#3998) dependency update + adjust Playwright setup + fix linter issue (#3994) demo with gif (#3995) [core] fix: allow browser globals in config files (#3992) [core] fix: restore --ozone-platform=wayland flag for reliable Wayland support (#3989) [core] auto create release notes with every push on develop (#3985) [core] chore: simplify Wayland start script (#3974) [gitignore] restore the old Git behavior for the default modules (#3968) [core] configure cspell to check default modules only and fix typos (#3955) [gitignore] restoring the old Git behavior for the CSS directory (#3954) feat(core): add server:watch script with automatic restart on file changes (#3920) [check_config] refactor: improve error handling (#3927) refactor: replace express-ipfilter with lightweight custom middleware (#3917) refactor: replace module-alias dependency with internal alias resolver (#3893) [dependencies] [chore] update dependencies and min. node version (#3986) [core] bump dependencies into december (#3982) Bump actions/checkout from 5 to 6 (#3972) Update deps, unpin parse5 (#3934) [core] Update deps and pin jsdom to v27.0.0 (#3925) chore: update dependencies (#3921) update deps, exclude node v23 (#3916) remove eslint warnings, add npm publish process to Collaboration.md (#3913) feat: add ESlint rule no-sparse-arrays for config check (#3911) chore: bump dependencies into october (#3909) [logging] logger: add calling filename as prefix on server side (#3926) [logger] Add prefixes to most Log messages (#3923) [modules/alert] Add new pt and pt-BR translations for Alert module and update global PT strings (#3965) [modules/calendar] add checksum to test whether calendar event list changed (#3988) [calendar] fix: prevent excessive fetching on client reload and refactor calendarfetcherutils.js (#3976) [calendar] refactor: migrate CalendarFetcher to ES6 class and improve error handling (#3959) [calendar] Show repeatingCountTitle only if yearDiff > 0 (#3949) [tests] suppress debug logs in CI environment + improve calendar symbol test stability (#3941) [calendar] chore: remove requiresVersion: "2.1.0" (#3932) [calendar] test: remove "Recurring event per timezone" test (#3929) [modules/compliments] [compliments] refactor: optimize loadComplimentFile method and add unit tests (#3969) fix: set compliments remote file minimum delay to 15 minutes (#3970) [compliments] fix: duplicate query param "?" in compliments module refresh url (#3967) [modules/newsfeed] [newsfeed] fix header layout issue (#3946) [modules/weather] [weatherprovider] update subclass language use override (#3914) [weather] fix wind-icon not showing in pirateweather (#3957) [weather] add error handling to weather fetch functions, including cors (#3791) remove deprecated ukmetoffice datapoint provider, cleanup .gitignore (#3952) fixes problems with daylight-saving-time in weather provider openmeteo (#3931) Fix for envcanada Provider to use updated Env Canada URL (#3919) [weather] feat: add configurable forecast date format option (#3918) [testing] testing: update "Enforce Pull-Request Rules" workflow (#3987) [core] refactor: replace XMLHttpRequest with fetch and migrate e2e tests to Playwright (#3950) [test] replace node-libgpiod with serialport in electron-rebuild workflow (#3945) [ci] Add concurrency to automated tests workflow to cancel outdated runs (#3943) [tests] migrate from jest to vitest (#3940) --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Karsten Hassel <[email protected]> Co-authored-by: Kristjan ESPERANTO <[email protected]> Co-authored-by: Ryan Williams <[email protected]> Co-authored-by: Veeck <[email protected]> Co-authored-by: Bugsounet - Cédric <[email protected]> Co-authored-by: Marc Landis <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: HeikoGr <[email protected]> Co-authored-by: Pedro Lamas <[email protected]> Co-authored-by: veeck <[email protected]> Co-authored-by: Magnus <[email protected]> Co-authored-by: Ikko Eltociear Ashimine <[email protected]> Co-authored-by: DevIncomin <[email protected]> Co-authored-by: Nathan <[email protected]> Co-authored-by: mixasgr <[email protected]> Co-authored-by: Savvas Adamtziloglou <[email protected]> Co-authored-by: Konstantinos <[email protected]> Co-authored-by: OWL4C <[email protected]> Co-authored-by: BugHaver <[email protected]> Co-authored-by: BugHaver <[email protected]> Co-authored-by: Koen Konst <[email protected]> Co-authored-by: Koen Konst <[email protected]> Co-authored-by: dathbe <[email protected]> Co-authored-by: Marcel <[email protected]> Co-authored-by: Kevin G. <[email protected]> Co-authored-by: Jboucly <[email protected]> Co-authored-by: Jboucly <[email protected]> Co-authored-by: Jarno <[email protected]> Co-authored-by: Jordan Welch <[email protected]> Co-authored-by: Blackspirits <[email protected]> Co-authored-by: Samed Ozdemir <[email protected]>
fix: set compliments remote file minimum delay to 15 minutes..extra *60 in there was making it 15 hours.