chore: use prettier --write --ignore-unknown in lint-staged to avoid errors on unsupported files#3888
Merged
rejas merged 2 commits intoMagicMirrorOrg:developfrom Sep 11, 2025
Conversation
…oid errors on unsupported files Prevents Prettier from failing when lint-staged passes unknown/binary files, making the pre-commit hook more robust. This is recommended when using asterisk: https://github.com/lint-staged/lint-staged#automatically-fix-code-style-with-prettier-for-any-format-prettier-supports
rejas
approved these changes
Sep 11, 2025
Collaborator
Author
|
By the way: It's actually somewhat good that we didn't have it before. Otherwise we wouldn't be formatting the |
Collaborator
thats the only downside of this PR: we would need to manually run prettier to find these un-linted file extension |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents
prettierfrom failing whenlint-stagedpasses unknown/binary files, making the pre-commit hook more robust.In concrete terms this could happen, when we, for example, add a new PNG file. Since we rarely do this, it has not been noticed so far.
This is recommended when using asterisk: https://github.com/lint-staged/lint-staged#automatically-fix-code-style-with-prettier-for-any-format-prettier-supports
before
after