Skip to content

refactor default modules: move scheduleTimer to one place#3837

Merged
rejas merged 4 commits intoMagicMirrorOrg:developfrom
khassel:mod_func
Jul 10, 2025
Merged

refactor default modules: move scheduleTimer to one place#3837
rejas merged 4 commits intoMagicMirrorOrg:developfrom
khassel:mod_func

Conversation

@khassel
Copy link
Collaborator

@khassel khassel commented Jul 8, 2025

see #3819

@khassel khassel marked this pull request as draft July 8, 2025 20:56
@khassel khassel marked this pull request as ready for review July 8, 2025 21:28
@khassel khassel requested a review from rejas July 8, 2025 21:28
@KristjanESPERANTO
Copy link
Collaborator

I would like to test something before merging, but don't have the time now.

@khassel
Copy link
Collaborator Author

khassel commented Jul 8, 2025

I would like to test something before merging, but don't have the time now.

o.k. for me, nothing urgent in this PR ...

@rejas rejas requested a review from KristjanESPERANTO July 9, 2025 08:42
@KristjanESPERANTO
Copy link
Collaborator

KristjanESPERANTO commented Jul 9, 2025

Oh, I actually wanted to push in my repo 🤦 Sorry! But with the last commit you can see my approach. I would like to avoid the additional use of module-alias and even drop it in the medium term. It prevents us from running MM under other runtimes like deno or bun (see #2934). If you don't like my approach, we can undo the commit 🙂

@khassel
Copy link
Collaborator Author

khassel commented Jul 9, 2025

Oh, I actually wanted to push in my repo 🤦 Sorry!

ups ... no problem ... I'm always afraid of doing this, so I added a separate (fake) push url for the original mm repo ...

But with the last commit you can see my approach. I would like to avoid the additional use of module-alias and even drop it in the medium term. It prevents us from running MM under other runtimes like deno or bun (see #2934). If you don't like my approach, we can undo the commit 🙂

LGTM (but it's over my js knowledge ...)

So as we both worked on this PR @rejas should merge it.

@KristjanESPERANTO
Copy link
Collaborator

Thanks for being understanding.

I added a separate (fake) push url for the original mm repo

That's a cool idea. I just did this on my setup 🙂

@rejas rejas merged commit a05eb23 into MagicMirrorOrg:develop Jul 10, 2025
12 of 13 checks passed
@khassel khassel deleted the mod_func branch July 15, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants