update dependencies, nail down node-ical version to 0.18.0#3566
Merged
sdetweil merged 2 commits intoMagicMirrorOrg:developfrom Sep 28, 2024
Merged
update dependencies, nail down node-ical version to 0.18.0#3566sdetweil merged 2 commits intoMagicMirrorOrg:developfrom
sdetweil merged 2 commits intoMagicMirrorOrg:developfrom
Conversation
Collaborator
Author
|
The failed test is caused by the downgrade of |
Contributor
|
You can tempory add We used this kind of exception some time ago |
efdfcea to
c9b6c21
Compare
Contributor
|
It's green now :) |
Collaborator
Author
|
yes, thanks! @sdetweil can you please review/merge? |
Collaborator
|
looks good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0.18.0instead of^0.18.0inpackage.jsonpackage-lock.json