fix double load of positions now that check:config at startup is active#3565
Merged
khassel merged 2 commits intoMagicMirrorOrg:developfrom Sep 28, 2024
Merged
fix double load of positions now that check:config at startup is active#3565khassel merged 2 commits intoMagicMirrorOrg:developfrom
khassel merged 2 commits intoMagicMirrorOrg:developfrom
Conversation
khassel
approved these changes
Sep 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
after adding check:config to the MM startup process, #3450, we accidentally discover module positions more than once, and write the file each time..
add a check to see if we have done this work already