add tests for minimal node version (currently v20.9.0)#3556
Merged
rejas merged 1 commit intoMagicMirrorOrg:developfrom Sep 24, 2024
Merged
add tests for minimal node version (currently v20.9.0)#3556rejas merged 1 commit intoMagicMirrorOrg:developfrom
rejas merged 1 commit intoMagicMirrorOrg:developfrom
Conversation
Collaborator
|
my scripts are already at 20.9.0 |
Collaborator
Author
yes, no change to last release, but I want to know when we have to change this number ... |
Collaborator
|
i think that is good too. |
KristjanESPERANTO
approved these changes
Sep 24, 2024
rejas
approved these changes
Sep 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Beside testing against node version
v20.xandv22.xwe should also test against the minimal node version, currentlyv20.9.0.This is for seeing changes in dependencies which needs higher node version as with the July-24-release, where we wrote
node >=20but shipped aneslintversion which requirednode>=20.9.0.