Fixes the UK Met Office Datahub provider#3499
Merged
sdetweil merged 2 commits intoMagicMirrorOrg:developfrom Jul 7, 2024
jargordon:UKMetOfficeFix
Merged
Fixes the UK Met Office Datahub provider#3499sdetweil merged 2 commits intoMagicMirrorOrg:developfrom jargordon:UKMetOfficeFix
sdetweil merged 2 commits intoMagicMirrorOrg:developfrom
jargordon:UKMetOfficeFix
Conversation
khassel
approved these changes
Jul 7, 2024
Collaborator
|
Thx for your PR. Since apiSecret is now removed as a config option, could you provide a PR in the https://github.com/MagicMirrorOrg/MagicMirror-Documentation repo to change that there too ? |
Contributor
Author
|
@rejas PR has been submitted for documentation update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3384
Changed the UKMetOfficeDataHub provider to the new API structure as per the documentation.
API Base URL updated.
Header information amended to the correct key name.
API Secret no longer required so removed.
Changelog updated to reflect the change.