Open-Meteo: Fix forecast and hourly weather to use real temperatures, not apparent temperatures#3468
Merged
rejas merged 3 commits intoMagicMirrorOrg:developfrom Jun 24, 2024
Conversation
… not apparent temperatures
Collaborator
|
changelog add a line in fixed section with the issue number and short description |
Collaborator
|
yes, looks good from my side also. You jsut have to add a line to the latest CHANGELOG and fix the conflict. Happy to merge your PR afterwards. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #3466, the Open-Meteo provider is using the apparent temperature ("Feels like") in the forecast and hourly weather reporting. This is contrary to expected behavior.
Note: I'm a little unclear on how I should be editing the
CHANGELOG.mdfile with this PR - happy to update this PR with a little guidance. This is my first attempted PR in this project.Let me know if there are any questions.