move suncalc dependency out of dev, as it is used by the clock module#3401
Merged
rejas merged 4 commits intoMagicMirrorOrg:developfrom Mar 22, 2024
Merged
move suncalc dependency out of dev, as it is used by the clock module#3401rejas merged 4 commits intoMagicMirrorOrg:developfrom
rejas merged 4 commits intoMagicMirrorOrg:developfrom
Conversation
rejas
requested changes
Mar 22, 2024
Collaborator
rejas
left a comment
rejas
left a comment
There was a problem hiding this comment.
shouldnt the lock file also get updated by this?
Collaborator
Author
|
I don't think so as the lock file is from npm install, right not install-mm |
Collaborator
Author
|
it is referenced in the lock file. and |
rejas
approved these changes
Mar 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
user reported problem with clock module, checking code found dependency on suncalc library, but it is not loaded in production mode.. move dependency