Changes the layout of the current weather module, targetting indoor values#3397
Merged
rejas merged 4 commits intoMagicMirrorOrg:developfrom Mar 23, 2024
Merged
Changes the layout of the current weather module, targetting indoor values#3397rejas merged 4 commits intoMagicMirrorOrg:developfrom
rejas merged 4 commits intoMagicMirrorOrg:developfrom
Conversation
tatyango
approved these changes
Mar 19, 2024
Collaborator
Thanks for the PR, looks nice. I dont have a good idea how to mock this myself. |
rejas
approved these changes
Mar 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
this PR should change the layout of the indoor values in the current_weather module.
Since the Indoor values are being passed into the module via a notification, I sadly do not know exactly how to write a test for this. Can you link me an example or tell me, how I can mock indoor values into this test?
Before:
After:
