Change multiday fullDay Event behaviour#3396
Merged
rejas merged 8 commits intoMagicMirrorOrg:developfrom Mar 28, 2024
Merged
Conversation
Collaborator
|
Thanks for the PR. Makes sense for me, but the tests are failing for it :-( |
Contributor
Author
|
Okay.. they were green before and as far as I see, nothing changed in the Code. Would you be fine that I edit the tests to only assert that the text "ends in" is contained, no matter how many days are following? That's the main goal of the PR. |
rejas
approved these changes
Mar 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey!
This PR should change the behaviour of starting fullDay events that last several days. The goal was to change the behavior of the "Starting today, ends T" (T=Tomorrow) event, so it should show how many days it will occur from the first day on
Before situation:
a fullDay event that started 'today' and ends several days later showed Today on the first day. The rest of the days it showed X days left.
Y => Yesterday
T => Tomorrow
Target situation with this commit:
a fullDay event that started 'today' shows 'X days left' from the first day on and 'Today' on the last day.