so, whats this PR about actually ;-) ?

so, whats this PR about actually ;-) ?

It’s a WIP for better fixes for #3291 and the underlying exdate issues. I’m still seeing breakthrough events that have been excluded showing up. Stay tuned…

@jkriegshauser note that we changed rrule processors this release,(dragged in from node-ical) and are seeing weird results. skipped dates (null returned where date should be)

@jkriegshauser note that we changed rrule processors this release,(dragged in from node-ical) and are seeing weird results. skipped dates (null returned where date should be)

Odd, where is the null date being returned?

from the rrule.between in calendarfetcherutils.js

					Log.debug(`Search for recurring events between: ${pastLocal} and ${futureLocal}`);
					let dates = rule.between(pastLocal, futureLocal, true, limitFunction);   // <---- here 
					Log.debug(`Title: ${event.summary}, with dates: ${JSON.stringify(dates)}`); // you can see them in the debug output here 
					dates = dates.filter((d) => {      // this filter added in this release to remove null entries which cause crash
						if (JSON.stringify(d) === "null") return false;
						else return true;
					});

from a user with problem

from a user with problem

@sdetweil thanks, can you provide a link to the forum comment? The URL in the image doesn't seem to take me anywhere.

@jkriegshauser
see
https://forum.magicmirror.builders/topic/18363/calendar-module-missing-recurring-events-schedule-after-7pm-est

@rejas @sdetweil @khassel this is ready for review now. Sam, I kept the null filtering that you mentioned above, and I believe this will also address the problems mentioned in the forum post above.

Thank you for your work! In case we need to look at the PR again later: Can you write in the initial comment what was changed? I think the text from the changelog would suffice.

Can you write in the initial comment what was changed? I think the text from the changelog would suffice.

I updated the description.

Ah I was just working on this.

Sorry, you can update again ...

I'm fine with this PR, can this be merged? @sdetweil @rejas

Alright, should be gtg now

@rejas @sdetweil Can this be merged? I've been running it on two local instances for a week and had no issues. @khassel gave approval above. I just resolved conflicts

Sorry for delaying this longer than needed. Thanks for your work (and the insane amount of tests ;-)
Now only some doc updates are needed ;-)