Show moon phase in clock module#3284
Merged
rejas merged 6 commits intoMagicMirrorOrg:developfrom Dec 13, 2023
Merged
Conversation
Contributor
Author
Collaborator
|
I like the idea and the implementation with emojis! 😃 Can you provide a screenshot of what it looked like before for comparison? I can't test it right now, but wasn't there a percentage behind the moon? |
Collaborator
Contributor
Author
|
I like that idea. I can take a swing at that over the weekend and push some updates! |
Contributor
Author
Collaborator
|
Thanks. Can you now prepare a PR for the Documentation repo? |
Collaborator
|
@rejas I'm getting > [email protected] test:prettier
> prettier . --check
Checking formatting...
[warn] js/class.js
[warn] Code style issues found in the above file. Run Prettier to fix.since this is merged on |
Collaborator
|
seems unrelated, maybe new deps |
rejas
pushed a commit
that referenced
this pull request
Dec 13, 2023
see title, should be merged because style tests are failing, see #3284 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This change replaces the font-awesome moon icon and percent-lit with an icon showing the current lunar phase.
It uses emoji, which may not be installed on all machines. The fallback text version is backwards (the dark part of the moon is text-color, which is normally black but white in MagicMirror).