Skip to content

Bump node-ical from 0.16.1 to 0.17.0#3278

Closed
dependabot[bot] wants to merge 1 commit intodevelopfrom
dependabot/npm_and_yarn/develop/node-ical-0.17.0
Closed

Bump node-ical from 0.16.1 to 0.17.0#3278
dependabot[bot] wants to merge 1 commit intodevelopfrom
dependabot/npm_and_yarn/develop/node-ical-0.17.0

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 1, 2023 •
edited
Loading

Bumps node-ical from 0.16.1 to 0.17.0.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Dec 1, 2023
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/develop/node-ical-0.17.0 branch from 21b8298 to 9361087 Compare December 1, 2023 18:15
@khassel
Copy link
Collaborator

khassel commented Dec 1, 2023

waiting for #3014

@rejas
Copy link
Collaborator

rejas commented Dec 1, 2023

also failing tests with this update...

@bugsounet
Copy link
Contributor

bugsounet commented Dec 1, 2023

Api change?

@sdetweil
Copy link
Collaborator

sdetweil commented Dec 1, 2023

no.. bug fix for MS and multi-location TZ ids and also removal of luxon library from RRULE lib dependencies

@sdetweil
Copy link
Collaborator

sdetweil commented Dec 1, 2023

that is a timing bug again as far as I can tell.. they all runs the same testcases..

@khassel
Copy link
Collaborator

khassel commented Dec 1, 2023

all tests are fine with new node-ical (did a local run), these are the "normal fails", see #3203

@sdetweil
Copy link
Collaborator

sdetweil commented Dec 1, 2023

I had not yet tested node-ical 0.17.0 for side impacts..

@rejas rejas mentioned this pull request Dec 4, 2023
Merged
@rejas
Copy link
Collaborator

rejas commented Dec 4, 2023

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/develop/node-ical-0.17.0 branch from 9361087 to ddd7583 Compare December 4, 2023 06:45
@rejas
Copy link
Collaborator

rejas commented Dec 4, 2023

all tests are fine with new node-ical (did a local run), these are the "normal fails", see #3203

did you try out node v20? or where di the tests run fine?

@sdetweil
Copy link
Collaborator

sdetweil commented Dec 4, 2023

I ran tests locally on node 20. no issues
but I am.looking for the odd moved repeating, or deleted repeating.. that we have trouble w today. so far so good got another month.. so no rush imho

@khassel
Copy link
Collaborator

khassel commented Dec 4, 2023

did you try out node v20? or where di the tests run fine?

can not explain why it worked last time.

Now the calendar e2e tests are failing reproducable:

node@48626ff2d77f:/opt/magic_mirror$ npx jest tests/e2e/modules/calendar_spec.js
(node:240) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
 FAIL   e2e  tests/e2e/modules/calendar_spec.js (189.832 s)
  Calendar module
    Default configuration
      ✕ should show the default maximumEntries of 10 (20002 ms)
      ✕ should show the default calendar symbol in each event (20000 ms)
    Custom configuration
      ✓ should show the custom maximumEntries of 5 (3983 ms)
      ✓ should show the custom calendar symbol in four events (202 ms)
      ✓ should show a customEvent calendar symbol in one event (200 ms)
      ✓ should show a customEvent calendar eventClass in one event (200 ms)
      ✓ should show two custom icons for repeating events (203 ms)
      ✕ should show two custom icons for day events (202 ms)
    Recurring event
      ✓ should show the recurring birthday event 6 times (1316 ms)
    exdate check
      ✓ should show the recurring event 51 times (excluded once) in a 364-day (inclusive) period (1353 ms)
    Events from multiple calendars
      ✕ should show multiple events with the same title and start time from different calendars (20000 ms)
    Recurring event per timezone
      ✓ should contain text "Mar 25th" in timezone UTC 12 (1306 ms)
      ✓ should contain text "Mar 25th" in timezone UTC 11 (1302 ms)
      ✓ should contain text "Mar 25th" in timezone UTC 10 (1309 ms)
      ✓ should contain text "Mar 25th" in timezone UTC 9 (1311 ms)
      ✓ should contain text "Mar 25th" in timezone UTC 8 (1304 ms)
      ✓ should contain text "Mar 25th" in timezone UTC 7 (1244 ms)
      ✓ should contain text "Mar 25th" in timezone UTC 6 (1338 ms)
      ✓ should contain text "Mar 25th" in timezone UTC 5 (1317 ms)
      ✓ should contain text "Mar 25th" in timezone UTC 4 (1313 ms)
      ✓ should contain text "Mar 25th" in timezone UTC 3 (1213 ms)
      ✓ should contain text "Mar 25th" in timezone UTC 2 (1316 ms)
      ✓ should contain text "Mar 25th" in timezone UTC 1 (1309 ms)
      ✓ should contain text "Mar 25th" in timezone UTC 0 (1384 ms)
      ✓ should contain text "Mar 25th" in timezone UTC -1 (1344 ms)
      ✓ should contain text "Mar 25th" in timezone UTC -2 (1335 ms)
      ✓ should contain text "Mar 25th" in timezone UTC -3 (1252 ms)
      ✓ should contain text "Mar 25th" in timezone UTC -4 (1645 ms)
      ✓ should contain text "Mar 25th" in timezone UTC -5 (1436 ms)
      ✓ should contain text "Mar 25th" in timezone UTC -6 (1250 ms)
      ✓ should contain text "Mar 25th" in timezone UTC -7 (1332 ms)
      ✓ should contain text "Mar 25th" in timezone UTC -8 (1341 ms)
      ✓ should contain text "Mar 25th" in timezone UTC -9 (1232 ms)
      ✓ should contain text "Mar 25th" in timezone UTC -10 (1554 ms)
      ✓ should contain text "Mar 25th" in timezone UTC -11 (1239 ms)
    Changed port
      ✕ should return TestEvents (19996 ms)
    Basic auth
      ✕ should return TestEvents (20004 ms)
    Basic auth by default
      ✕ should return TestEvents (20001 ms)
    Basic auth backward compatibility configuration: DEPRECATED
      ✕ should return TestEvents (20001 ms)
    Fail Basic auth
      ✓ should show Unauthorized error (1205 ms)

The test should show two custom icons for day events retrieves 3 custom icons, all other fails are timeouts, I think because they are waiting for elements which are not delivered. So for me it looks like new node-ical version has logical changes which are breaking the tests.

Setup: I'm running node v21.3.0 and I'm using a docker container for the tests which is build on last develop.

For this test I updated package.json with new node_ical and removed luxon.

@khassel
Copy link
Collaborator

khassel commented Dec 4, 2023

Now it's getting really strange:

Running with node v20.10.0 all calendar e2e tests are failing with ReferenceError: navigator is not defined

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/develop/node-ical-0.17.0 branch from ddd7583 to 4f39ffd Compare December 13, 2023 21:50
@dependabot
Bump node-ical from 0.16.1 to 0.17.0
60840ad 
Bumps [node-ical](https://github.com/jens-maus/node-ical) from 0.16.1 to 0.17.0.
- [Commits](https://github.com/jens-maus/node-ical/commits/0.17.0)

---
updated-dependencies:
- dependency-name: node-ical
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/develop/node-ical-0.17.0 branch from 4f39ffd to 60840ad Compare December 13, 2023 21:50
@bugsounet
Copy link
Contributor

bugsounet commented Dec 27, 2023

tested with node-ical v0.17.1 and node v21.5.0:

 PASS   e2e  tests/e2e/modules/calendar_spec.js (71.213 s)
  Calendar module
    Default configuration
      ✓ should show the default maximumEntries of 10 (1565 ms)
      ✓ should show the default calendar symbol in each event (202 ms)
    Custom configuration
      ✓ should show the custom maximumEntries of 5 (1461 ms)
      ✓ should show the custom calendar symbol in four events (203 ms)
      ✓ should show a customEvent calendar symbol in one event (203 ms)
      ✓ should show a customEvent calendar eventClass in one event (261 ms)
      ✓ should show two custom icons for repeating events (204 ms)
      ✓ should show two custom icons for day events (208 ms)
    Recurring event
      ✓ should show the recurring birthday event 6 times (1443 ms)
    Events from multiple calendars
      ✓ should show multiple events with the same title and start time from different calendars (1427 ms)
    Recurring event per timezone
      ✓ should contain text "Mar 25th" in timezone UTC 12 (1349 ms)
      ✓ should contain text "Mar 25th" in timezone UTC 11 (1766 ms)
      ✓ should contain text "Mar 25th" in timezone UTC 10 (1338 ms)
      ✓ should contain text "Mar 25th" in timezone UTC 9 (1698 ms)
      ✓ should contain text "Mar 25th" in timezone UTC 8 (1487 ms)
      ✓ should contain text "Mar 25th" in timezone UTC 7 (1387 ms)
      ✓ should contain text "Mar 25th" in timezone UTC 6 (1329 ms)
      ✓ should contain text "Mar 25th" in timezone UTC 5 (1406 ms)
      ✓ should contain text "Mar 25th" in timezone UTC 4 (1420 ms)
      ✓ should contain text "Mar 25th" in timezone UTC 3 (1473 ms)
      ✓ should contain text "Mar 25th" in timezone UTC 2 (1960 ms)
      ✓ should contain text "Mar 25th" in timezone UTC 1 (1705 ms)
      ✓ should contain text "Mar 25th" in timezone UTC 0 (1374 ms)
      ✓ should contain text "Mar 25th" in timezone UTC -1 (1357 ms)
      ✓ should contain text "Mar 25th" in timezone UTC -2 (1475 ms)
      ✓ should contain text "Mar 25th" in timezone UTC -3 (1786 ms)
      ✓ should contain text "Mar 25th" in timezone UTC -4 (1628 ms)
      ✓ should contain text "Mar 25th" in timezone UTC -5 (1870 ms)
      ✓ should contain text "Mar 25th" in timezone UTC -6 (1913 ms)
      ✓ should contain text "Mar 25th" in timezone UTC -7 (1559 ms)
      ✓ should contain text "Mar 25th" in timezone UTC -8 (1492 ms)
      ✓ should contain text "Mar 25th" in timezone UTC -9 (1599 ms)
      ✓ should contain text "Mar 25th" in timezone UTC -10 (1463 ms)
      ✓ should contain text "Mar 25th" in timezone UTC -11 (1528 ms)
    Changed port
      ✓ should return TestEvents (1900 ms)
    Basic auth
      ✓ should return TestEvents (3500 ms)
    Basic auth by default
      ✓ should return TestEvents (1849 ms)
    Basic auth backward compatibility configuration: DEPRECATED
      ✓ should return TestEvents (2135 ms)
    Fail Basic auth
      ✓ should show Unauthorized error (1561 ms)

ok for me

@rejas
Copy link
Collaborator

rejas commented Dec 27, 2023

@dependabot update

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 27, 2023

Superseded by #3308.

@dependabot dependabot bot closed this Dec 27, 2023
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/develop/node-ical-0.17.0 branch December 27, 2023 09:38
@khassel
Copy link
Collaborator

khassel commented Dec 27, 2023

ok for me

can confirm it works now, maybe because of new node-ical release 0.17.1 ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@khassel @rejas @bugsounet @sdetweil