avoid overriding config.js when running tests#3205
Merged
rejas merged 3 commits intoMagicMirrorOrg:developfrom Sep 22, 2023
Merged
avoid overriding config.js when running tests#3205rejas merged 3 commits intoMagicMirrorOrg:developfrom
config.js when running tests#3205rejas merged 3 commits intoMagicMirrorOrg:developfrom
Conversation
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## develop #3205 +/- ##
===========================================
+ Coverage 25.21% 25.29% +0.08%
===========================================
Files 54 54
Lines 11925 11925
===========================================
+ Hits 3007 3017 +10
+ Misses 8918 8908 -10 |
rejas
requested changes
Sep 21, 2023
Collaborator
rejas
left a comment
There was a problem hiding this comment.
thx. the files dont get deleted at the end. maybe delete them after the test?
Collaborator
Author
done, also for file |
rejas
approved these changes
Sep 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
solves #3201