Skip to content

avoid overriding config.js when running tests#3205

Merged
rejas merged 3 commits intoMagicMirrorOrg:developfrom
khassel:test-config
Sep 22, 2023
Merged

avoid overriding config.js when running tests#3205
rejas merged 3 commits intoMagicMirrorOrg:developfrom
khassel:test-config

Conversation

@khassel
Copy link
Collaborator

@khassel khassel commented Sep 21, 2023

solves #3201

@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2023

Codecov Report

Merging #3205 (521e65f) into develop (a67a0b6) will increase coverage by 0.08%.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           develop    #3205      +/-   ##
===========================================
+ Coverage    25.21%   25.29%   +0.08%     
===========================================
  Files           54       54              
  Lines        11925    11925              
===========================================
+ Hits          3007     3017      +10     
+ Misses        8918     8908      -10     

see 2 files with indirect coverage changes

Copy link
Collaborator

@rejas rejas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx. the files dont get deleted at the end. maybe delete them after the test?

@khassel
Copy link
Collaborator Author

khassel commented Sep 21, 2023

maybe delete them after the test?

done, also for file tests/configs/port_variable.js which is created by template_spec test

@khassel khassel requested a review from rejas September 21, 2023 22:04
@rejas rejas merged commit 95ec309 into MagicMirrorOrg:develop Sep 22, 2023
@khassel khassel deleted the test-config branch September 24, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants