Update yr provider to new api #3197
Merged
rejas merged 4 commits intoMagicMirrorOrg:developfrom Sep 20, 2023
Merged
Conversation
rejas
requested changes
Sep 15, 2023
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## develop #3197 +/- ##
===========================================
- Coverage 25.56% 25.30% -0.26%
===========================================
Files 53 54 +1
Lines 11481 11922 +441
===========================================
+ Hits 2935 3017 +82
- Misses 8546 8905 +359
|
rejas
reviewed
Sep 15, 2023
Collaborator
rejas
left a comment
rejas
left a comment
There was a problem hiding this comment.
Thx, will check once I am back at a pc later today's
rejas
approved these changes
Sep 15, 2023
Collaborator
|
One mall thing: run the linting task over the files and commit again. |
Contributor
Author
|
linting task? |
Collaborator
|
Npm run lint:prettier |
rejas
requested changes
Sep 16, 2023
Collaborator
rejas
left a comment
rejas
left a comment
There was a problem hiding this comment.
Please run npm run lint:prettier and commit the changes
rejas
approved these changes
Sep 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some changes after yr api was deprecated and replaced with a new one.
Fixes #3189