Update weathergov.js - new pull request against develop branch#3195
Merged
rejas merged 3 commits intoMagicMirrorOrg:developfrom Sep 25, 2023
Merged
Update weathergov.js - new pull request against develop branch#3195rejas merged 3 commits intoMagicMirrorOrg:developfrom
rejas merged 3 commits intoMagicMirrorOrg:developfrom
Conversation
Fixed issue with probability of precipitation not showing up on hourly or daily forecast
Contributor
Author
|
Ok I tried creating a new pull request. Sorry never actually contributed to github before |
Collaborator
|
No worries, there's a first time for everyone :-) |
rejas
requested changes
Sep 16, 2023
Collaborator
rejas
left a comment
rejas
left a comment
There was a problem hiding this comment.
Please also add a CHANGELOG entry
rejas
approved these changes
Sep 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3182
Fixed issue with probability of precipitation not showing up on hourly or daily forecast
Hello and thank you for wanting to contribute to the MagicMirror² project
Please make sure that you have followed these 4 rules before submitting your Pull Request:
Note: Sometimes the development moves very fast. It is highly
recommended that you update your branch of
developbefore creating apull request to send us your changes. This makes everyone's lives
easier (including yours) and helps us out on the development team.
Thanks again and have a nice day!