Skip to content

Add class event calendar#3193

Merged
rejas merged 5 commits intoMagicMirrorOrg:developfrom
Ybbet:addClassEventCalendar
Sep 20, 2023
Merged

Add class event calendar#3193
rejas merged 5 commits intoMagicMirrorOrg:developfrom
Ybbet:addClassEventCalendar

Conversation

@Ybbet
Copy link
Contributor

@Ybbet Ybbet commented Sep 14, 2023

Hello,
This pull request allows you to add a class to the tr of the event sought in customEvents. You must enter the class with the "eventClass" option.

@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2023

Codecov Report

Merging #3193 (41ba2b0) into develop (fa7c7fc) will decrease coverage by 0.01%.
Report is 1 commits behind head on develop.
The diff coverage is 0.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           develop    #3193      +/-   ##
===========================================
- Coverage    25.28%   25.27%   -0.01%     
===========================================
  Files           54       54              
  Lines        11892    11896       +4     
===========================================
  Hits          3007     3007              
- Misses        8885     8889       +4     
Files Changed Coverage Δ
js/electron.js 0.00% <0.00%> (ø)
modules/default/calendar/calendar.js 0.00% <0.00%> (ø)

@rejas
Copy link
Collaborator

rejas commented Sep 14, 2023

Thx for the PR. Could you run prettier over the code and commit again?

@Ybbet Ybbet requested a review from rejas September 20, 2023 10:31
@rejas rejas merged commit a67a0b6 into MagicMirrorOrg:develop Sep 20, 2023
@rejas
Copy link
Collaborator

rejas commented Sep 20, 2023

Thx for the PR. Now can you create a PR for this to update the Documentation in the MM-Doc repo?

@Ybbet Ybbet deleted the addClassEventCalendar branch September 20, 2023 22:19
@Ybbet
Copy link
Contributor Author

Ybbet commented Sep 20, 2023

You welcome. I will create it tomorrow. 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants