electron: add missing fullscreen option#3192
Merged
rejas merged 1 commit intoMagicMirrorOrg:developfrom Sep 14, 2023
Merged
Conversation
Contributor
|
works but ... webPreferences: {
fullscreen: false
}not work |
Collaborator
Author
electronOptions: {
width: 800,
height: 600,
fullscreen: false,
},works on my side |
Contributor
|
tested with your |
Collaborator
Author
|
strange, I used this in /* MagicMirror Config Sample
*
* By Michael Teeuw https://michaelteeuw.nl
* MIT Licensed.
*
* For more information on how you can configure this file
* see https://docs.magicmirror.builders/configuration/introduction.html
* and https://docs.magicmirror.builders/modules/configuration.html
*/
let config = {
electronOptions: {
width: 800,
height: 600,
fullscreen: false,
},
address: "0.0.0.0", // Address to listen on, can be:
// - "localhost", "127.0.0.1", "::1" to listen on loopback interface
// - another specific IPv4/6 to listen on a specific interface
// - "0.0.0.0", "::" to listen on any interface
// Default, when address config is left out or empty, is "localhost"
port: 8080,
...and it is 800x600 with taskbar, tested on a pi 4. Did you test on a pi? |
Contributor
|
ah shit, it's me ... I have set it in webPreferences of electronOptions :/ So it's works :) |
Contributor
|
(we open the bets? e2e will work or not ??) |
Collaborator
Author
I hate the e2e tests ... |
Contributor
|
it will works |
rejas
approved these changes
Sep 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up for #3187
@bugsounet can you please confirm that this now works for you?