Skip to content

added automatic client page reload#3188

Merged
rejas merged 1 commit intoMagicMirrorOrg:developfrom
khassel:client-refresh
Sep 13, 2023
Merged

added automatic client page reload#3188
rejas merged 1 commit intoMagicMirrorOrg:developfrom
khassel:client-refresh

Conversation

@khassel
Copy link
Collaborator

@khassel khassel commented Sep 11, 2023

solution for #3105

not sure if updatenotification is the right place, so opinions?

now impleneted in main.js

@khassel khassel marked this pull request as draft September 11, 2023 22:24
@bugsounet
Copy link
Contributor

Hi, not sure it's better place
because some user disable updatenotification and it's not the fonction of it :/

For me, maybe best place is main.js
when all promise of all DOMs are resolved (All DOM_OBJECTS_CREATED of all modules)
I consider that all modules are ready and you code can start from line 67 of main.js

In this case checkServerInterval will be a global feature and not a module feature

@khassel khassel marked this pull request as ready for review September 12, 2023 22:53
@khassel khassel changed the title added automatic client page reload in module updatenotification added automatic client page reload Sep 12, 2023
@rejas rejas merged commit 7a1591b into MagicMirrorOrg:develop Sep 13, 2023
@khassel khassel deleted the client-refresh branch September 13, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants