respect width/height (no fullscreen) if set in electronOptions...#3187
Merged
rejas merged 1 commit intoMagicMirrorOrg:developfrom Sep 13, 2023
Merged
respect width/height (no fullscreen) if set in electronOptions...#3187rejas merged 1 commit intoMagicMirrorOrg:developfrom
rejas merged 1 commit intoMagicMirrorOrg:developfrom
Conversation
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## develop #3187 +/- ##
===========================================
+ Coverage 25.22% 25.31% +0.08%
===========================================
Files 54 54
Lines 11852 11851 -1
===========================================
+ Hits 2990 3000 +10
+ Misses 8862 8851 -11
|
khassel
force-pushed
the
electron-fullscreen
branch
from
f2667a8 to
4cf3c7b
Compare
Contributor
|
Really!? |
Contributor
Collaborator
Author
|
you are right, I tested this on a system without taskbar, will look again into this ... |
Collaborator
|
Shall we revert this? |
Collaborator
Author
no, will provide another PR later
no idea at the moment |
Contributor
|
(revert not sure, You have commit something else after) @khassel will give us something better in the next commit. I trust ;) |
rejas
pushed a commit
that referenced
this pull request
Sep 14, 2023
follow up for #3187 @bugsounet can you please confirm that this now works for you?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... in
config.js.Solves #3174
With getting width/heigt from
electron.screen.getPrimaryDisplay().workAreaSizeintroduced with #3161 the solution was to remove thesetFullscreenline.So per default the fullscreen resolution is used but when someone now uses
electronOptions.width/electronOptions.heightinconfig.jsthese parameters are used and so "no fullscreen" is possible.