Added Override Notification Option to Weather Module#3178
Merged
rejas merged 11 commits intoMagicMirrorOrg:developfrom Sep 8, 2023
Merged
Added Override Notification Option to Weather Module#3178rejas merged 11 commits intoMagicMirrorOrg:developfrom
rejas merged 11 commits intoMagicMirrorOrg:developfrom
Conversation
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## develop #3178 +/- ##
===========================================
- Coverage 26.15% 25.97% -0.19%
===========================================
Files 53 54 +1
Lines 11502 11621 +119
===========================================
+ Hits 3008 3018 +10
- Misses 8494 8603 +109
... and 2 files with indirect coverage changes 📢 Have feedback on the report? Share it here. |
rejas
requested changes
Sep 5, 2023
Collaborator
|
Could you check the jsdoc warnings here: https://github.com/MichMich/MagicMirror/actions/runs/6105958927?pr=3178 @NolanKingdon ? |
…on/MagicMirror into weather-override-notification
rejas
approved these changes
Sep 8, 2023
Collaborator
|
Thx for the work @NolanKingdon will merge it now. Could you also provide a PR to update the docs in the https://github.com/MichMich/MagicMirror-Documentation/ repo? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3126
Added the option
allowOverrideNotificationtoweather.js. This allows the module to receive theCURRENT_WEATHER_OVERRIDEnotification. The expected payload for this notification is a full/partialweatherObjectthat is used to supplement/replace the existingweatherObjectreturned by whichever weather provider is in use.No visual changes.
First time contributing - let me know if I've missed something 🙂