fix electron width/heigth when using xrandr under bullseye#3161
Merged
rejas merged 1 commit intoMagicMirrorOrg:developfrom Aug 12, 2023
Merged
fix electron width/heigth when using xrandr under bullseye#3161rejas merged 1 commit intoMagicMirrorOrg:developfrom
rejas merged 1 commit intoMagicMirrorOrg:developfrom
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## develop #3161 +/- ##
===========================================
+ Coverage 25.53% 25.60% +0.06%
===========================================
Files 53 53
Lines 11492 11501 +9
===========================================
+ Hits 2935 2945 +10
+ Misses 8557 8556 -1
|
rejas
approved these changes
Aug 12, 2023
rejas
pushed a commit
that referenced
this pull request
Sep 13, 2023
) ... in `config.js`. Solves #3174 With getting width/heigt from `electron.screen.getPrimaryDisplay().workAreaSize` introduced with #3161 the solution was to remove the `setFullscreen` line. So per default the fullscreen resolution is used but when someone now uses `electronOptions.width`/`electronOptions.height` in `config.js` these parameters are used and so "no fullscreen" is possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uses
electron.screen.getPrimaryDisplay().workAreaSizeunder electron to get the screen size.If this fails the current defaults (800x600) are used.
This solves some problems with xrandr under bullseye where the sreen comes up with 800x600 instead of fullscreen, e.g. described here.
Tested this on my pi setup.
By the way, the Issue #1919 is back on my side (not related to this PR) ...