fix clientOnly not starting up after async startup added in 2.23#3154
Merged
khassel merged 1 commit intoMagicMirrorOrg:developfrom Jul 16, 2023
Merged
fix clientOnly not starting up after async startup added in 2.23#3154khassel merged 1 commit intoMagicMirrorOrg:developfrom
khassel merged 1 commit intoMagicMirrorOrg:developfrom
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## develop #3154 +/- ##
==========================================
Coverage ? 25.62%
==========================================
Files ? 53
Lines ? 11492
Branches ? 0
==========================================
Hits ? 2945
Misses ? 8547
Partials ? 0
|
khassel
approved these changes
Jul 16, 2023
Collaborator
|
could you point to the commit where it was removed? cant find it ATM |
Collaborator
Author
|
PR #3091 |
rejas
approved these changes
Jul 16, 2023
Collaborator
Author
|
I commented it out in my test prototype |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3151
app.whenReady() was removed when async changes made, needed for clientonly in electron.js