3rd party modules updater for updatenotification by bugsounet · Pull Request #3150 · MagicMirrorOrg/MagicMirror

bugsounet · 2023-07-14T11:34:03Z

Added my (modified) updater main core into updatenotification default module

Missing: callback display in MM² (i will code it after)

new part of configuration added:

		updates: [
			// array of module update commands
			{
				// with embed npm script
				"MMM-Test": "npm run update"
			},
			{
				// with "complex" process
				"MMM-OtherSample": "rm -rf package-lock.json && git reset --hard && git pull && npm install"
			},
			{
				// with git pull && npm install
				"MMM-OtherSample2": "git pull && npm install"
			},
			{
				// with a simple git pull
				"MMM-OtherSample3": "git pull"
			}
		],
		updateTimeout: 2 * 60 * 1000, // max update duration
		updateAutorestart: false // autoRestart MM when update done ?

@khassel: i need your help
I don't use docker, maybe you can help me for this:
How can i check if MM² is running inside a docker ? (from MM² main core)
Actually, I check if we use pm2 or not.
I have to check if docker is used or not too
last time you tell me: "you can't use updater with docker", so I want to check and deny any update if docker used

update deps incl. electron to v25, fix stylelint segmentation dump (#…

bugsounet · 2023-07-14T11:45:12Z

humm... I don't want to push new package-lock now but it's needed

codecov-commenter · 2023-07-14T11:53:32Z

Codecov Report

Merging #3150 (b7dffce) into develop (66b29ec) will increase coverage by 0.48%.
Report is 1 commits behind head on develop.
The diff coverage is 39.71%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           develop    #3150      +/-   ##
===========================================
+ Coverage    25.19%   25.68%   +0.48%     
===========================================
  Files           54       55       +1     
  Lines        11933    12202     +269     
===========================================
+ Hits          3007     3134     +127     
- Misses        8926     9068     +142

Files	Coverage Δ
modules/default/calendar/calendar.js	`0.00% <ø> (ø)`
modules/default/updatenotification/node_helper.js	`78.84% <50.00%> (+5.51%)`	⬆️
...s/default/updatenotification/updatenotification.js	`0.00% <0.00%> (ø)`
...odules/default/updatenotification/update_helper.js	`45.08% <45.08%> (ø)`

... and 1 file with indirect coverage changes

bugsounet · 2023-07-14T14:40:35Z

I think that pm2 will correct Vulnerabilities soon

khassel · 2023-07-14T17:45:11Z

How can i check if MM² is running inside a docker ? (from MM² main core)
last time you tell me: "you can't use updater with docker", so I want to check and deny any update if docker used

are you talking of restarting? Because updater in general has no problem with docker ...

Simple method is to check if the file /.dockerenv exists.

bugsounet · 2023-07-22T09:46:37Z

maybe it's better to use 'pm2 prettylist' with child_process exec function instead of the pm2 library.
It will correct Vulnerabilities, no ?
because I think they are in no hurry to fix this

bugsounet · 2023-08-02T15:02:15Z

ah... how solve this translations_spec.js error ?

I have added some new translations part in en and fr json file
I'm not able to translate all ;) ;)

what's missing ?

bugsounet · 2023-08-02T15:48:40Z

Ok i found: de json file is considered as default (I thought it was 'en')
I will see with my de translator :)

khassel · 2023-08-02T20:35:12Z

Ok i found: de json file is considered as default (I thought it was 'en')

yes, there was a reason to switch but I forgot it ...

I will see with my de translator :)

can review this before merge ...

bugsounet · 2023-08-02T20:40:51Z

yes @khassel : maybe this

bugsounet · 2023-08-27T17:19:15Z

It's not totaly Done:

I have to Clean some not needed parts
make Class Docs

modules/default/updatenotification/node_helper.js

…agicMirror into updates-notification

bugsounet · 2023-09-03T08:59:41Z

@rejas: It's ok for me for review

Can you restart again test suite because ... as usual "ReferenceError: moment is not defined" error is again there ...
thx ;)

bugsounet · 2023-09-08T07:58:03Z

Ah the misery, ... I hate resolving a conflict in the package-lock.json

I'll leave it like this for now, we'll fix it when we push it

You have to test anyway

bugsounet · 2023-09-10T08:15:58Z

@rejas:

will we put it in place for v2.26.x?
I don't think we will have time to do the tests/review and write the doc

rejas · 2023-09-11T08:42:18Z

Next version is 2.25, so lets move it to v2.26, ok?

bugsounet · 2023-10-07T19:31:33Z

@rejas

Hi, this seems ready for review

khassel · 2023-10-07T21:51:39Z

concerning running as docker container: Restarting should work with this code (if container is set to restart automatically), will test this after this is merged on develop.

bugsounet · 2023-11-04T09:45:55Z

This test suite is very random :/
it works half the time locally...

Test Suites: 40 passed, 40 total
Tests:       574 passed, 574 total
Snapshots:   9 passed, 9 total

ping: @rejas

what do we do with this PR?
Merge it or review again ;)

bugsounet · 2023-11-09T16:35:56Z

ping @rejas
ping: connect: Network is unreachable

rejas

lets see how it behaves in develop :-)

rejas · 2023-11-09T22:22:44Z

could you bring it up to the latest develop so we see the tests become green? thx for your patience!

khassel · 2023-11-20T20:23:19Z

@bugsounet I was looking for the new restart config option for updatenotification but couldn't find this in the documentation repo (maybe I'm blind).

So can you please provide a Documentation-PR for the new features you implemented here? Thanks!

bugsounet · 2023-11-21T04:52:17Z

It's planned ;)
I will do it before release, don't worry ;)

bugsounet · 2023-12-24T12:44:42Z

Finally... I'm not sure that I will have time to write it before release :/

bugsounet and others added 13 commits June 7, 2023 17:18

Merge pull request #1 from MichMich/develop

34a9e7d

update deps incl. electron to v25, fix stylelint segmentation dump (#…

sendUpdatesNotifications feature

6444af3

missing const

8f38ea7

mismake, sorry

7206f27

set sendUpdatesNotifications feature to false

a03803e

sync develop sources of MM²

4350b65

Remote force check update (#3127)

8dcb8f8

Update dependencies and fix dependabot issues (#3134)

3a96ea7

Develop sync

272c2d3

Merge branch 'updates-notification' into develop-source

777748a

Develop source sync

2bfda92

add updater to updatenotification default module

c8d512d

correct for eslint

89ea2a3

update package-lock

ba28952

correct pm2 restarting

c9e453f

bugsounet added 5 commits August 2, 2023 09:43

Develop

2990410

Merge branch 'updates-notification' into develop-source

d64aa4c

Develop source

c001822

delete pm2 dependency and use child_process

375311c

screen callbacks of Updates status with translations

d14cb4c

added de.json translation file (thx to @lxne)

beded0b

Merge branch 'develop' into updates-notification

e0a63d4

bugsounet commented Aug 27, 2023

View reviewed changes

modules/default/updatenotification/node_helper.js Outdated Show resolved Hide resolved

bugsounet added 3 commits August 27, 2023 19:26

delete updatesCallbacks (not used)

133e124

Merge branch 'updates-notification' of https://github.com/bugsounet/M…

3a0eeee

…agicMirror into updates-notification

comment how this class work

5b11ae0

bugsounet requested a review from rejas September 1, 2023 11:35

Merge branch 'develop' into updates-notification

3274c2b

khassel mentioned this pull request Sep 9, 2023

3rd party modules updater for updatenotification #3142

Closed

rejas added this to the 2.26 milestone Sep 11, 2023

bugsounet added 2 commits October 7, 2023 15:52

Merge branch 'develop' into updates-notification

898c1d7

ChangeLog move to v2.26

b7dffce

khassel approved these changes Oct 7, 2023

View reviewed changes

Merge branch 'develop' into updates-notification

aec008b

rejas approved these changes Nov 9, 2023

View reviewed changes

force sync from develop

bf1238d

rejas merged commit 203e864 into MagicMirrorOrg:develop Nov 10, 2023

bugsounet deleted the updates-notification branch December 1, 2023 12:32

Uh oh!

Conversation

bugsounet commented Jul 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bugsounet commented Jul 14, 2023

Uh oh!

codecov-commenter commented Jul 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

bugsounet commented Jul 14, 2023

Uh oh!

khassel commented Jul 14, 2023

Uh oh!

bugsounet commented Jul 22, 2023

Uh oh!

bugsounet commented Aug 2, 2023

Uh oh!

bugsounet commented Aug 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

khassel commented Aug 2, 2023

Uh oh!

bugsounet commented Aug 2, 2023

Uh oh!

bugsounet commented Aug 27, 2023

Uh oh!

Uh oh!

bugsounet commented Sep 3, 2023

Uh oh!

bugsounet commented Sep 8, 2023

Uh oh!

bugsounet commented Sep 10, 2023

Uh oh!

rejas commented Sep 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bugsounet commented Oct 7, 2023

Uh oh!

khassel commented Oct 7, 2023

Uh oh!

bugsounet commented Nov 4, 2023

Uh oh!

bugsounet commented Nov 9, 2023

Uh oh!

rejas left a comment

Choose a reason for hiding this comment

Uh oh!

rejas commented Nov 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

khassel commented Nov 20, 2023

Uh oh!

bugsounet commented Nov 21, 2023

Uh oh!

bugsounet commented Dec 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bugsounet commented Jul 14, 2023 •

edited

Loading

codecov-commenter commented Jul 14, 2023 •

edited

Loading

bugsounet commented Aug 2, 2023 •

edited

Loading

rejas commented Sep 11, 2023 •

edited

Loading

rejas commented Nov 9, 2023 •

edited

Loading