fix updatenotification where no branch is checked out ...#3136
Merged
rejas merged 1 commit intoMagicMirrorOrg:developfrom Jun 27, 2023
Merged
fix updatenotification where no branch is checked out ...#3136rejas merged 1 commit intoMagicMirrorOrg:developfrom
rejas merged 1 commit intoMagicMirrorOrg:developfrom
Conversation
rejas
approved these changes
Jun 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... but e.g. a version tag
fixes #3130
This happens e.g. in my docker image where I use the version tag to get the mm sources.
With this PR the error message is avoided and there will be never an updatenotification when using a tag. This is o.k. because a tag should never be moved.