Updates notification#3119
Updates notification#3119rejas merged 5 commits intoMagicMirrorOrg:developfrom bugsounet:updates-notification
Conversation
update deps incl. electron to v25, fix stylelint segmentation dump (#…
| } | ||
|
|
||
| return gitResultList; | ||
| return this.gitResultList; |
There was a problem hiding this comment.
now that gitResultList is global we dont need to return it, or do we?
There was a problem hiding this comment.
yes it's a global value only on the GitHelper class (constructor) but not available somewhere else (like this.gitRepos)
you have to query GitHelper to retrieve this value
I prefert save the result of getRepos in a global value
Why ? because, I reuse it for checkUpdates
it saves time (perhaps minimal) to pick up from the node helper repos values of performFetch function and do the processing.
The values are already present elsewhere (gitHelper) so much to exploit them directly
| refreshInterval: 24 * 60 * 60 * 1000, // one day | ||
| ignoreModules: [] | ||
| ignoreModules: [], | ||
| sendUpdatesNotifications: true |
There was a problem hiding this comment.
I think we should set it to false for one release cycle so that we can test the functionality in the main branch and set it to true later.
There was a problem hiding this comment.
Sure, As you want.
I'm only suggesting, it's a you to decide :)
|
Nice PR and functionality. Adding a test for this would be a nice addition (cherry on top) :-) |
|
After, we (or I) can create a template for an auto-update of a module for testing (it's only for modules of developer) Note:
Is this what you are looking for? |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## develop #3119 +/- ##
===========================================
+ Coverage 25.59% 25.61% +0.02%
===========================================
Files 53 53
Lines 11435 11464 +29
===========================================
+ Hits 2927 2937 +10
- Misses 8508 8527 +19
|
sorry, dont get what you mean. is it about testing? will merge the PR anyway even without tests, they can be done anytime later |
4 participants
Hi,
Like some default modules, I propose to send an
UPDATESnotification in an array with the git information of these modulesThis allows developers to create their own auto-update system (which I've been using in my case since 3 years, with automatic things)
Of course, for security reasons
MagicMirroris excluded