Adding experimental UV Index support for weather module#3108
Adding experimental UV Index support for weather module#3108rejas merged 22 commits intoMagicMirrorOrg:developfrom
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## develop #3108 +/- ##
===========================================
+ Coverage 25.61% 25.64% +0.02%
===========================================
Files 53 53
Lines 11427 11435 +8
===========================================
+ Hits 2927 2932 +5
- Misses 8500 8503 +3
|
|
The last batch of tests failed because "uv_index" is not Kebap Case, which is unfixable since the API provides it only as such. |
|
you can use around the troublesome block |
The error comes from modules/default/weather/weather.css where you define a class with that name (and reference in the njk template). So those places you can fix. The API param name doesnt trigger the error. |
|
But thanks for the PR. COuld you provide a screenshot of the whole weather look now? |
…nges, fixed look to conform to other module data
|
I am pretty sure i fixed everything and made it look nice |
4 participants
This pr adds (config.js toggleable) showUV_Index to the hourly and current weather modules, with right now only openmeteo configured to supply the data. Other providers could have support too by adding
uv_indexto current and hourly.For example the current weather looks like
positioned after sunset in the top row.
The following "hacks" are included and could be fixed to make it cleaner, but the functionality is wanted and it works without problem.
hourly.njkwhich is not how precipitation is handled.The following are minor things that might not need fixing:
.njk's. This could be made changeable by a config but does not seem relevant since wi-hot is not used by anything else as far as i can tell.