Use single config backup file when config.template is used#3104
Merged
khassel merged 2 commits intoMagicMirrorOrg:developfrom May 15, 2023
oscarb:patch-1
Merged
Use single config backup file when config.template is used#3104khassel merged 2 commits intoMagicMirrorOrg:developfrom oscarb:patch-1
khassel merged 2 commits intoMagicMirrorOrg:developfrom
oscarb:patch-1
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## develop #3104 +/- ##
===========================================
+ Coverage 25.53% 25.57% +0.04%
===========================================
Files 53 53
Lines 11420 11420
===========================================
+ Hits 2916 2921 +5
+ Misses 8504 8499 -5
|
Collaborator
|
Thx for the PR, I am fine with it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy
config.jsto a singleconfig.js-oldfile whenever aconfig.templateis present, instead of usingDate()as a suffix. Creating files with a timestamp suffix means that whenever Magic Mirror is restarted or recreated a new file is written into the config directory.Benefits: