Add tests for some weather utils#3103
Merged
khassel merged 9 commits intoMagicMirrorOrg:developfrom May 15, 2023
Merged
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## develop #3103 +/- ##
===========================================
+ Coverage 25.61% 25.66% +0.05%
===========================================
Files 53 53
Lines 11421 11422 +1
===========================================
+ Hits 2926 2932 +6
+ Misses 8495 8490 -5
|
rejas
commented
May 13, 2023
| } else if (this.firstEvent && this.firstEvent.location) { | ||
| params += `q=${this.firstEvent.location}`; | ||
| } else { | ||
| // TODO hide doesnt exist! |
Collaborator
Author
There was a problem hiding this comment.
@MichMich any idea what your idea behind the hide here was?
Collaborator
There was a problem hiding this comment.
is this ready to merge or do you need this answer before?
Collaborator
Author
There was a problem hiding this comment.
@MichMich answer isnt needed for merging, we can clean that up later (hence the TODO)
khassel
approved these changes
May 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.