Add openmeteo precipitation probability#3099
Merged
rejas merged 3 commits intoMagicMirrorOrg:developfrom May 13, 2023
Merged
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## develop #3099 +/- ##
===========================================
+ Coverage 25.54% 25.57% +0.03%
===========================================
Files 53 53
Lines 11415 11420 +5
===========================================
+ Hits 2916 2921 +5
Misses 8499 8499
|
Collaborator
|
Thx for the PR, could you add a CHANGELOG entry too? |
Contributor
Author
|
Like this? I have no former git/pr experience... |
Collaborator
Like this indeed. Now only thing failing the checks is the linter. Please run 'npm run lint:prettier' and commit the changes. Thx in advance! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the size of the commit there is no need for a long explanation:
Openmeteo supports precipitation probability in api, but the weather provider .js had no support for it. After adding 4 lines it works as expected. This should have no consequences on other files but improves usability for (imo) the best weather provider.