fix: don't filter out ongoing full day events in Calendar module (#3095)#3096
Merged
khassel merged 2 commits intoMagicMirrorOrg:developfrom May 15, 2023
Merged
fix: don't filter out ongoing full day events in Calendar module (#3095)#3096khassel merged 2 commits intoMagicMirrorOrg:developfrom
khassel merged 2 commits intoMagicMirrorOrg:developfrom
Conversation
Param `hideOngoing` is by default set to `false`, but the event filtering handles full day & non-full day events inconsistently. For `non-full day` ongoing and upcoming events are returned, while for `full day` only upcoming events where returned.
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## develop #3096 +/- ##
===========================================
+ Coverage 25.54% 25.67% +0.12%
===========================================
Files 53 53
Lines 11415 11416 +1
===========================================
+ Hits 2916 2931 +15
+ Misses 8499 8485 -14
|
rejas
approved these changes
May 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3095.
Param
hideOngoingis by default set tofalse, but the event filtering handlesfull day&non-full dayevents inconsistently. Fornon-full dayongoing and upcoming events are returned, while forfull dayonly upcoming events where returned.