Skip to content

use node v20 in github workflow (replacing v19)#3093

Merged
rejas merged 1 commit intoMagicMirrorOrg:developfrom
khassel:node20
Apr 22, 2023
Merged

use node v20 in github workflow (replacing v19)#3093
rejas merged 1 commit intoMagicMirrorOrg:developfrom
khassel:node20

Conversation

@khassel
Copy link
Collaborator

@khassel khassel commented Apr 21, 2023

additional:

  • update deps
  • suppress more unwanted log errors in e2e tests
  • add .gitattributes
  • fix prettier/js warnings

@codecov-commenter
Copy link

codecov-commenter commented Apr 21, 2023

Codecov Report

Merging #3093 (772f90c) into develop (7e58b38) will decrease coverage by 0.36%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           develop    #3093      +/-   ##
===========================================
- Coverage    25.94%   25.58%   -0.36%     
===========================================
  Files           53       53              
  Lines        11572    11415     -157     
===========================================
- Hits          3002     2921      -81     
+ Misses        8570     8494      -76     
Impacted Files Coverage Δ
clientonly/index.js 0.00% <ø> (ø)
js/app.js 79.88% <ø> (-0.44%) ⬇️
js/check_config.js 0.00% <ø> (ø)
js/class.js 72.22% <ø> (-0.26%) ⬇️
js/fetch.js 100.00% <ø> (ø)
js/loader.js 0.00% <ø> (ø)
js/main.js 0.00% <ø> (ø)
js/node_helper.js 98.57% <ø> (-0.04%) ⬇️
js/server.js 95.79% <ø> (-0.11%) ⬇️
js/server_functions.js 90.90% <ø> (-0.43%) ⬇️
... and 21 more

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@khassel khassel requested a review from rejas April 21, 2023 20:32
@rejas rejas merged commit b80485b into MagicMirrorOrg:develop Apr 22, 2023
rejas pushed a commit that referenced this pull request Apr 22, 2023
@khassel khassel deleted the node20 branch June 5, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants