Skip to content

fix electron not running under windows (after async changes)#3091

Merged
rejas merged 1 commit intoMagicMirrorOrg:developfrom
khassel:electron-win-fix
Apr 12, 2023
Merged

fix electron not running under windows (after async changes)#3091
rejas merged 1 commit intoMagicMirrorOrg:developfrom
khassel:electron-win-fix

Conversation

@khassel
Copy link
Collaborator

@khassel khassel commented Apr 11, 2023

fixes #3083

tested under windows 11 and linux.

@codecov-commenter
Copy link

Codecov Report

Merging #3091 (2f38615) into develop (4e33690) will increase coverage by 0.04%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           develop    #3091      +/-   ##
===========================================
+ Coverage    25.98%   26.03%   +0.04%     
===========================================
  Files           53       53              
  Lines        11583    11582       -1     
===========================================
+ Hits          3010     3015       +5     
+ Misses        8573     8567       -6     
Impacted Files Coverage Δ
js/electron.js 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rejas rejas merged commit 979f4ec into MagicMirrorOrg:develop Apr 12, 2023
@khassel khassel deleted the electron-win-fix branch April 16, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants