Add no-param-reassign from eslint #3089
Conversation
js/app.js
Outdated
| modules.forEach((module) => { | ||
| loadModule(module); | ||
| }); | ||
| Log.log("All module helpers loaded."); |
There was a problem hiding this comment.
greatly simplified this, it shouldnt break exisiting module loading at least for me.
| Log.error("Parameter mismatch in module.hide: callback is not an optional parameter!"); | ||
| usedOptions = callback; | ||
| usedCallback = function () {}; | ||
| } |
There was a problem hiding this comment.
no idea why this was handled this way from the beginning by @MichMich
callback was never optional, but now some modules might be relying on this function call the way it is. Thats why I added an error warning here so that it might help people write better modules ...
| callback = function () {}; | ||
| Log.error("Parameter mismatch in module.show: callback is not an optional parameter!"); | ||
| usedOptions = callback; | ||
| usedCallback = function () {}; |
There was a problem hiding this comment.
same thing as in hide module...
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## develop #3089 +/- ##
===========================================
- Coverage 25.98% 25.98% -0.01%
===========================================
Files 53 53
Lines 11583 11572 -11
===========================================
- Hits 3010 3007 -3
+ Misses 8573 8565 -8
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
rejas
force-pushed
the
cleanup/no-param-reassign
branch
from
21cc32d to
2722047
Compare
KristjanESPERANTO
left a comment
KristjanESPERANTO
left a comment
There was a problem hiding this comment.
Nice work! It looks good to me. The modules I use also work.
|
ready for review :-) |
cleanup tests
mostly for styles
rejas
force-pushed
the
cleanup/no-param-reassign
branch
from
c5ed435 to
cc5a87f
Compare
4 participants
While waiting for the easterbunny I cleaned up some bad coding practice :-)
Very open for comments especially regarding the places I commented myself...